-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiled sql for ephemeral models #3139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwigley
force-pushed
the
fix/ephemeral-compile-sql
branch
from
March 2, 2021 22:53
e7737f9
to
55ad292
Compare
jtcohen6
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huzzah! LGTM in local testing. This is code is cavernous; nice spelunking.
gshank
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
kwigley
force-pushed
the
fix/ephemeral-compile-sql
branch
from
March 8, 2021 19:19
5f425ce
to
4bb7a84
Compare
kwigley
pushed a commit
that referenced
this pull request
May 4, 2021
…e-sql Fix compiled sql for ephemeral models
4 tasks
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
…e-sql Fix compiled sql for ephemeral models automatic commit by git-black, original commits: bf1ad6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3056
Description
write valid sql for ephemeral models, still some work to clean up compilation code
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.