Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiled sql for ephemeral models #3139

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Mar 2, 2021

resolves #3056

Description

write valid sql for ephemeral models, still some work to clean up compilation code

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 2, 2021
@kwigley kwigley changed the base branch from develop to 0.19.latest March 2, 2021 22:43
@kwigley kwigley self-assigned this Mar 2, 2021
@kwigley kwigley marked this pull request as ready for review March 3, 2021 13:57
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! LGTM in local testing. This is code is cavernous; nice spelunking.

Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@kwigley kwigley merged commit 21c6294 into 0.19.latest Mar 12, 2021
@kwigley kwigley deleted the fix/ephemeral-compile-sql branch March 12, 2021 17:01
kwigley pushed a commit that referenced this pull request May 4, 2021
…e-sql

Fix compiled sql for ephemeral models
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
…e-sql

Fix compiled sql for ephemeral models


automatic commit by git-black, original commits:
  bf1ad6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTE no longer interpolated into target compiled query for ephemeral model
3 participants