New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voucher to receipt case definitions for DE #70
Merged
TSchmiedlechner
merged 22 commits into
fiskaltrust:master
from
christian-rogobete:de-receipt-case-definitions
Jun 10, 2020
Merged
Add voucher to receipt case definitions for DE #70
TSchmiedlechner
merged 22 commits into
fiskaltrust:master
from
christian-rogobete:de-receipt-case-definitions
Jun 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-rogobete
requested review from
StefanKert,
steininger and
TSchmiedlechner
as code owners
May 6, 2020 20:29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and proposals.
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
christian-rogobete
changed the title
Add voucher to receipt case definitions
Add voucher to receipt case definitions for DE
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supplementary clarifications.
Many thanks for the good explanations!
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
Outdated
Show resolved
Hide resolved
…stain-rogobete/interface-doc into de-receipt-case-definitions * 'de-receipt-case-definitions' of https://github.com/christain-rogobete/interface-doc: connect voucher examples # Conflicts: # doc/appendix-de-kassensichv/receipt-case-definitions/receipt-case-definitions.md
christian-rogobete
added
the
in progress
This issue is already in progress to be resolved.
label
May 22, 2020
christian-rogobete
added
the
waiting-for-review
This pull request is finished and is waiting for review.
label
Jun 8, 2020
christian-rogobete
removed
the
in progress
This issue is already in progress to be resolved.
label
Jun 8, 2020
TSchmiedlechner
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.