Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher-fails-to-start-on-Linux-without-root-permissions#135 #138

Merged

Conversation

pawelvds
Copy link
Contributor

No description provided.

@pawelvds pawelvds requested a review from a team as a code owner December 13, 2023 10:11
@pawelvds pawelvds linked an issue Dec 20, 2023 that may be closed by this pull request
- Moved directory creation and permission setting from LinuxSystemD to CommonHandler to ensure directory setup at every launcher start
- Simplified LinuxSystemD by removing directory setup code
- Changed RunProcess method in ServiceInstaller from protected to public
@volllly
Copy link
Contributor

volllly commented Jan 3, 2024

Since we're updating the whole systemd handling in #141 I'd like to remove the changes to src/fiskaltrust.Launcher/ServiceInstallation/LinuxSystemD.cs from this PR 😅

@pawelvds pawelvds marked this pull request as draft January 4, 2024 13:11
@pawelvds pawelvds marked this pull request as ready for review January 4, 2024 13:56
@pawelvds pawelvds merged commit 13d53e3 into main Jan 9, 2024
15 checks passed
@pawelvds pawelvds deleted the Launcher-fails-to-start-on-Linux-without-root-permissions#135 branch January 9, 2024 10:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launcher fails to start on Linux without root permissions
2 participants