Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#139 - Fix Launcher not starting on Systemd & multiple installations #154

Merged
merged 37 commits into from
Jan 25, 2024

Conversation

forsthug
Copy link
Contributor

@forsthug forsthug commented Jan 12, 2024

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

{Summary of the changes}

Description

{Detail}

Fixes #{issue number}

@forsthug forsthug requested a review from a team as a code owner January 12, 2024 05:58
@volllly
Copy link
Contributor

volllly commented Jan 12, 2024

When running the install command twice I get the following error message from systemd
fiskaltrust-161f695b-98f1-47e8-b99d-f8259b009841.service: Service has more than one ExecStart= setting, which is only allowed for Type=oneshot services. Refusing.

#139

@volllly
Copy link
Contributor

volllly commented Jan 12, 2024

Ok so systemd started the launcher correctly but the install command never stopped. The last message was Enable service. and then it hung.

I'm thinking that

return (await ProcessHelper.RunProcess("systemctl", new[] { "enable", _serviceName, "-q" })).exitCode;
this command does wait for something in the launcher to signal that it has started up? 🤔

@volllly volllly marked this pull request as draft January 12, 2024 12:11
@forsthug
Copy link
Contributor Author

When running the install command twice I get the following error message from systemd fiskaltrust-161f695b-98f1-47e8-b99d-f8259b009841.service: Service has more than one ExecStart= setting, which is only allowed for Type=oneshot services. Refusing.

#139

The service did not start the middleware before, this was fixed with this PR- The problem of multiple install tries will be fixed now.,

@forsthug forsthug closed this Jan 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
@forsthug
Copy link
Contributor Author

Ok so systemd started the launcher correctly but the install command never stopped. The last message was Enable service. and then it hung.

I'm thinking that

return (await ProcessHelper.RunProcess("systemctl", new[] { "enable", _serviceName, "-q" })).exitCode;

this command does wait for something in the launcher to signal that it has started up? 🤔

This command is not sending a start event. But when you look at the implementation of Backgroundservice, this is not the way they work. That`s way the timeout is 0 for the systemd service. One reasons way the service never started.

@forsthug
Copy link
Contributor Author

..

@forsthug forsthug reopened this Jan 15, 2024
@volllly
Copy link
Contributor

volllly commented Jan 15, 2024

/azp run

@forsthug forsthug changed the title #139 - Fix Launcher not starting on Systemd #139 - Fix Launcher not starting on Systemd & multiple installations Jan 15, 2024
@volllly volllly linked an issue Jan 25, 2024 that may be closed by this pull request
@volllly volllly marked this pull request as ready for review January 25, 2024 09:02
@volllly volllly merged commit 2acb164 into main Jan 25, 2024
15 checks passed
@volllly volllly deleted the #139-Error-installing-launcher-twice branch January 25, 2024 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing launcher twice
2 participants