DE: cbReceiptReference exception thrown for wrong receiptCase

[saschaknapp]

Description:
When a single open transaction in the TSE should be closed then the "Failed-Transaction-Receipt" can be used. In such cases the cbReceiptReference has to be set or the following exception is thrown:
CbReceiptReference must be set for one transaction! If you want to close multiple transactions, pass an array value for 'CurrentStartedTransactionNumbers' via ftReceiptCaseData

Issue:
As this exception is only relevant for the "Fail-transaction-Receipt" it should only be thrown in the described case. But currently the middleware throws this exception even when the "Fail-transaction-receipt" isn't used. Example receipt request:

<ftReceiptCase type="number">4919338172267167745</ftReceiptCase>
  <ftReceiptCaseData type="string">KAZ060001185#03.05.22#07:41:05</ftReceiptCaseData>
  <ftCashboxID type="string">XXXXX</ftCashboxID>
  <cbTerminalID type="string">XXXXX</cbTerminalID>
  <cbUser type="string">{"ID":"XXXXXX","Name":""}</cbUser>
  <cbCustomer type="string">{"CustomerId":"","CustomerName":"","CustomerName2":"","CustomerStreet":"","CustomerStreet2":"","CustomerZip":"","CustomerCity":"","CustomerCountry":"","CustomerVATId":""}</cbCustomer>
  <cbReceiptReference type="string"></cbReceiptReference>
  <cbPreviousReceiptReference type="string">KAZ060001185</cbPreviousReceiptReference>
  <cbReceiptMoment type="string">2022-05-03T05:41:05Z</cbReceiptMoment>
  <cbChargeItems type="array">
    <item type="object">
      <ProductNumber type="string"></ProductNumber>
      <Description type="string">Vorgangsbeginn</Description>
      <a:item item="Description 2" type="string" xmlns:a="item"></a:item>
      <a:item item="Description 3" type="string" xmlns:a="item"></a:item>
      <Quantity type="number">0</Quantity>
      <UnitPrice type="number">0</UnitPrice>
      <Amount type="number">0</Amount>
      <VATRate type="number">0</VATRate>
      <VATAmount type="number">0</VATAmount>
      <ftChargeItemCase type="string">4919338167972134912</ftChargeItemCase>
      <ftChargeItemCaseData type="string">{"Reason Code":"Cashbox Verkauf Prozeß"}</ftChargeItemCaseData>
      <Moment type="string">2022-05-03T05:41:05Z</Moment>
    </item>
    <item type="object">
      <ProductNumber type="string"></ProductNumber>
      <Description type="string">Buche Wechselgeld aus</Description>
      <a:item item="Description 2" type="string" xmlns:a="item"></a:item>
      <a:item item="Description 3" type="string" xmlns:a="item"></a:item>
      <Quantity type="number">-1</Quantity>
      <UnitPrice type="number">-1054.32</UnitPrice>
      <Amount type="number">-1054.32</Amount>
      <VATRate type="number">0</VATRate>
      <VATAmount type="number">0</VATAmount>
      <ftChargeItemCase type="string">4919338167972135059</ftChargeItemCase>
      <ftChargeItemCaseData type="string">{Schließe Cashbox}</ftChargeItemCaseData>
      <Moment type="string">2022-05-03T05:41:05Z</Moment>
    </item>
  </cbChargeItems>
  <cbPayItems type="array">
    <item type="object">
      <Quantity type="number">-1</Quantity>
      <Amount type="number">-1054.32</Amount>
      <Description type="string">Buche Wechselgeld aus</Description>
      <ftPayItemCase type="string">4919338167972135000</ftPayItemCase>
      <ftPayItemCaseData type="string">{Schließe Cashbox}</ftPayItemCaseData>
      <Moment type="string">2022-05-03T05:41:05Z</Moment>
    </item>
  </cbPayItems>  

This is a regular receiptRequest with a "Failed receipt" flag and therefore shouldn't result in this exception. Possible cause: The condition that checks if the receipt is a "Fail-transaction-receipt" is negated and that might result in all receipts being checked except the relevant "Fail-transaction-receipt" if (string.IsNullOrEmpty(request.cbReceiptReference) && !request.IsFailTransactionReceipt() && !string.IsNullOrEmpty(request.ftReceiptCaseData) && !request.ftReceiptCaseData.Contains("CurrentStartedTransactionNumbers"))

middleware/queue/src/fiskaltrust.Middleware.Localization.QueueDE/SignProcessorDE.cs

Line 41 in b3849f7

if (string.IsNullOrEmpty(request.cbReceiptReference) && !request.IsFailTransactionReceipt() && !string.IsNullOrEmpty(request.ftReceiptCaseData) && !request.ftReceiptCaseData.Contains("CurrentStartedTransactionNumbers"))

[forsthug]

done