Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup temporary file on error #286

Closed
volllly opened this issue May 16, 2024 · 0 comments · Fixed by #284
Closed

Cleanup temporary file on error #286

volllly opened this issue May 16, 2024 · 0 comments · Fixed by #284
Labels
bug Something isn't working

Comments

@volllly
Copy link
Contributor

volllly commented May 16, 2024

In #284 we introduced a FileStream using a temporary file.

This file is deleted after the operation is completed here.
If an exception is thrown in the method the file will not be deleted.
Since we yield we can not put this in a finally block.

We need to find a way to cleanup this file if an error happens.
@volllly volllly added the bug Something isn't working label May 16, 2024
@volllly volllly linked a pull request May 21, 2024 that will close this issue
#281 Export tse out of memory #284
Merged
4 tasks
@volllly volllly closed this as completed May 21, 2024
volllly pushed a commit that referenced this issue Jun 4, 2024
@forsthug
Merge remote-tracking branch 'origin/#282-Finalize-and-test-Austrian-…
ef65b3e 
…1.3-Queue-implementation' into #286-Finalize-and-test-French-1.3-Queue-implementation
volllly pushed a commit that referenced this issue Jun 4, 2024
@forsthug
Merge remote-tracking branch 'origin/main' into #286-Finalize-and-tes…
fafec01 
…t-French-1.3-Queue-implementation
volllly pushed a commit that referenced this issue Jun 4, 2024
@forsthug
Merge pull request #274 from fiskaltrust/#286-Finalize-and-test-Frenc…
45094ca 
…h-1.3-Queue-implementation

#286 finalize and test french 1.3 queue implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#281 Export tse out of memory fiskaltrust/middleware
1 participant
@volllly