Drop support for Node.js v14, enable prefer-event-target `prefer-st…

…ring-replace-all` in recommended config
fisker · Apr 23, 2023 · 42ce833 · 42ce833
1 parent a9337e8
commit 42ce833
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -15,15 +15,14 @@ jobs:
       fail-fast: false
       matrix:
         node-version:
-          - 18
+          - 20
           - 16
-          - 14
         os:
           - ubuntu-latest
           - windows-latest
-        exclude:
+        include:
           - os: ubuntu-latest
-            node-version: 16
+            node-version: 18
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

diff --git a/configs/recommended.js b/configs/recommended.js
@@ -83,8 +83,7 @@ module.exports = {
 		'unicorn/prefer-dom-node-dataset': 'error',
 		'unicorn/prefer-dom-node-remove': 'error',
 		'unicorn/prefer-dom-node-text-content': 'error',
-		// TODO: Enable this by default when targeting Node.js 16.
-		'unicorn/prefer-event-target': 'off',
+		'unicorn/prefer-event-target': 'error',
 		'unicorn/prefer-export-from': 'error',
 		'unicorn/prefer-includes': 'error',
 		'unicorn/prefer-json-parse-buffer': 'off',
@@ -107,8 +106,7 @@ module.exports = {
 		'unicorn/prefer-set-has': 'error',
 		'unicorn/prefer-set-size': 'error',
 		'unicorn/prefer-spread': 'error',
-		// TODO: Enable this by default when targeting Node.js 16.
-		'unicorn/prefer-string-replace-all': 'off',
+		'unicorn/prefer-string-replace-all': 'error',
 		'unicorn/prefer-string-slice': 'error',
 		'unicorn/prefer-string-starts-ends-with': 'error',
 		'unicorn/prefer-string-trim-start-end': 'error',