Fix message

fisker · May 9, 2024 · 5d4a63a · 5d4a63a
1 parent f82fcdd
commit 5d4a63a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/rules/consistent-empty-array-spread.js b/rules/consistent-empty-array-spread.js
@@ -3,7 +3,7 @@ const {getStaticValue} = require('@eslint-community/eslint-utils');
 
 const MESSAGE_ID = 'consistent-empty-array-spread';
 const messages = {
-	[MESSAGE_ID]: 'Prefer using empty {{replacementDescription}} since the {{anotherNodePosition}} is {{problemNodeDescription}}.',
+	[MESSAGE_ID]: 'Prefer using empty {{replacementDescription}} since the {{anotherNodePosition}} is {{anotherNodeDescription}}.',
 };
 
 const isEmptyArrayExpression = node =>
@@ -32,14 +32,14 @@ const cases = [
 	{
 		oneSidePredicate: isEmptyStringLiteral,
 		anotherSidePredicate: isArray,
-		problemNodeDescription: 'a string',
+		anotherNodeDescription: 'an array',
 		replacementDescription: 'array',
 		replacementCode: '[]',
 	},
 	{
 		oneSidePredicate: isEmptyArrayExpression,
 		anotherSidePredicate: isString,
-		problemNodeDescription: 'an array',
+		anotherNodeDescription: 'a string',
 		replacementDescription: 'string',
 		replacementCode: '\'\'',
 	},
@@ -48,7 +48,7 @@ const cases = [
 function createProblem({
 	problemNode,
 	anotherNodePosition,
-	problemNodeDescription,
+	anotherNodeDescription,
 	replacementDescription,
 	replacementCode,
 }) {
@@ -58,7 +58,7 @@ function createProblem({
 		data: {
 			replacementDescription,
 			anotherNodePosition,
-			problemNodeDescription,
+			anotherNodeDescription,
 		},
 		fix: fixer => fixer.replaceText(problemNode, replacementCode),
 	};

diff --git a/test/snapshots/consistent-empty-array-spread.mjs.md b/test/snapshots/consistent-empty-array-spread.mjs.md
@@ -29,7 +29,7 @@ Generated by [AVA](https://avajs.dev).
     `␊
       1 | [␊
     > 2 | 	...(test ? [] : "ab"),␊
-        | 	           ^^ Prefer using empty string since the alternate is an array.␊
+        | 	           ^^ Prefer using empty string since the alternate is a string.␊
       3 | 	...(test ? "ab" : []),␊
       4 | ];␊
     `
@@ -40,7 +40,7 @@ Generated by [AVA](https://avajs.dev).
       1 | [␊
       2 | 	...(test ? [] : "ab"),␊
     > 3 | 	...(test ? "ab" : []),␊
-        | 	                  ^^ Prefer using empty string since the consequent is an array.␊
+        | 	                  ^^ Prefer using empty string since the consequent is a string.␊
       4 | ];␊
     `
 
@@ -72,7 +72,7 @@ Generated by [AVA](https://avajs.dev).
       1 | const STRING = "ab";␊
       2 | [␊
     > 3 | 	...(test ? [] : STRING),␊
-        | 	           ^^ Prefer using empty string since the alternate is an array.␊
+        | 	           ^^ Prefer using empty string since the alternate is a string.␊
       4 | 	...(test ? STRING : []),␊
       5 | ];␊
     `
@@ -84,7 +84,7 @@ Generated by [AVA](https://avajs.dev).
       2 | [␊
       3 | 	...(test ? [] : STRING),␊
     > 4 | 	...(test ? STRING : []),␊
-        | 	                    ^^ Prefer using empty string since the consequent is an array.␊
+        | 	                    ^^ Prefer using empty string since the consequent is a string.␊
       5 | ];␊
     `
 
@@ -113,7 +113,7 @@ Generated by [AVA](https://avajs.dev).
     `␊
       1 | [␊
     > 2 | 	...(test ? "" : [a, b]),␊
-        | 	           ^^ Prefer using empty array since the alternate is a string.␊
+        | 	           ^^ Prefer using empty array since the alternate is an array.␊
       3 | 	...(test ? [a, b] : ""),␊
       4 | ];␊
     `
@@ -124,7 +124,7 @@ Generated by [AVA](https://avajs.dev).
       1 | [␊
       2 | 	...(test ? "" : [a, b]),␊
     > 3 | 	...(test ? [a, b] : ""),␊
-        | 	                    ^^ Prefer using empty array since the consequent is a string.␊
+        | 	                    ^^ Prefer using empty array since the consequent is an array.␊
       4 | ];␊
     `
 
@@ -163,7 +163,7 @@ Generated by [AVA](https://avajs.dev).
       2 | [␊
       3 | 	/* hole */,␊
     > 4 | 	...(test ? "" : ARRAY),␊
-        | 	           ^^ Prefer using empty array since the alternate is a string.␊
+        | 	           ^^ Prefer using empty array since the alternate is an array.␊
       5 | 	/* hole */,␊
       6 | 	...(test ? ARRAY : ""),␊
       7 | 	/* hole */,␊
@@ -179,7 +179,7 @@ Generated by [AVA](https://avajs.dev).
       4 | 	...(test ? "" : ARRAY),␊
       5 | 	/* hole */,␊
     > 6 | 	...(test ? ARRAY : ""),␊
-        | 	                   ^^ Prefer using empty array since the consequent is a string.␊
+        | 	                   ^^ Prefer using empty array since the consequent is an array.␊
       7 | 	/* hole */,␊
       8 | ];␊
     `
@@ -202,5 +202,5 @@ Generated by [AVA](https://avajs.dev).
 
     `␊
     > 1 | [...(foo ? "" : [])]␊
-        |            ^^ Prefer using empty array since the alternate is a string.␊
+        |            ^^ Prefer using empty array since the alternate is an array.␊
     `
diff --git a/test/snapshots/consistent-empty-array-spread.mjs.snap b/test/snapshots/consistent-empty-array-spread.mjs.snap