[pull] main from sindresorhus:main

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,6 +1,7 @@
 ---
 name: Bug report
 about: A rule isn't working as it should?
+labels: bug
 ---
 
 <!-- ✨ Thanks for reporting a bug! ➡️ Please don't ignore this template -->

.github/ISSUE_TEMPLATE/rule_change.yml

@@ -0,0 +1,55 @@
+name: Rule change
+description: A rule could be improved or extended?
+title: "`rule-name`: "
+labels:
+  - change request
+  - evaluating
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Before opening a new issue:
+        - Look for existing [open or closed rule proposals](https://github.com/sindresorhus/eslint-plugin-unicorn/issues?q=is:issue+label%25enhancement)
+        - [Report a bug](https://github.com/sindresorhus/eslint-plugin-unicorn/issues/new?assignees=&labels=&projects=&template=bug_report.md) instead if it's a false positive
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: Description
+      description: Explain the improvement you would like to see.
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: Fail
+      description: Specify examples of code that should be detected.
+      value: |
+        ```js
+        var replace = 'me';
+        ```
+
+        ```js
+        function foo() {
+        	var replace = 'me';
+        	return replace;
+        }
+        ```
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: Pass
+      description: Specify examples of code that would be accepted in its place.
+      value: |
+        ```js
+        const replace = 'me';
+        ```
+
+        ```js
+        function foo() {
+        	return 'me';
+        }
+        ```
+  - type: textarea
+    attributes:
+      label: Additional Info

.github/ISSUE_TEMPLATE/rule_proposal.yml

@@ -49,6 +49,12 @@ body:
           return 'me';
         }
         ```
+  - type: input
+    validations:
+      required: true
+    attributes:
+      label: Proposed rule name
+      placeholder: no-invalid-rule-name
   - type: textarea
     attributes:
       label: Additional Info

.github/funding.yml

@@ -0,0 +1,4 @@
+github: [sindresorhus, fisker]
+open_collective: sindresorhus
+buy_me_a_coffee: sindresorhus
+custom: https://sindresorhus.com/donate

.github/workflows/main.yml

@@ -29,7 +29,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
-      - run: npm install --legacy-peer-deps
+      - run: npm install
       - run: npx ava
   lint-test:
     runs-on: ${{ matrix.os }}
@@ -44,7 +44,7 @@ jobs:
         with:
           # Locked due to the difference of `zlib.gzipSync()` between Node.js versions
           node-version: 20
-      - run: npm install --legacy-peer-deps
+      - run: npm install
       - run: npm run lint
       - run: npx del-cli test/snapshots --verbose
       # Force update snapshots, https://github.com/avajs/ava/discussions/2754
@@ -62,7 +62,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
-      - run: npm install --legacy-peer-deps
+      - run: npm install
       - run: npm run run-rules-on-codebase
   integration:
     name: Integration test (${{ matrix.group }})
@@ -85,5 +85,5 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
-      - run: npm install --legacy-peer-deps
+      - run: npm install
       - run: npm run integration -- --group ${{ matrix.group }}

.github/workflows/smoke-test.yml

@@ -9,13 +9,10 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
-      - run: |
-          npm install
-          npm link
-          npm link eslint-plugin-unicorn
-      - uses: AriPerkkio/eslint-remote-tester-run-action@v4
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+      - run: npm install
+      - uses: AriPerkkio/eslint-remote-tester-run-action@v5
         with:
           issue-title: "Results of weekly scheduled smoke test"
-          eslint-remote-tester-config: test/smoke/eslint-remote-tester.config.js
+          eslint-remote-tester-config: test/smoke/eslint-remote-tester.config.mjs

.npmpackagejsonlintrc.json

@@ -7,15 +7,16 @@
 		"prefer-alphabetical-optionalDependencies": "error",
 		"prefer-alphabetical-bundledDependencies": "error",
 		"prefer-alphabetical-scripts": "error",
-		"prefer-caret-version-dependencies": [
+		"prefer-caret-version-dependencies": "error",
+		"prefer-caret-version-devDependencies": [
 			"error",
 			{
 				"exceptions": [
-					"eslint-plugin-unicorn"
+					"eslint-plugin-internal-rules",
+					"eslint-doc-generator"
 				]
 			}
 		],
-		"prefer-caret-version-devDependencies": "error",
 		"prefer-scripts": [
 			"error",
 			[

configs/flat-config-base.js

@@ -1,10 +1,8 @@
 'use strict';
-const eslintrc = require('@eslint/eslintrc');
-
-const {globals} = eslintrc.Legacy.environments.get('es2024');
+const globals = require('globals');
 
 module.exports = {
 	languageOptions: {
-		globals,
+		globals: globals.builtin,
 	},
 };

docs/rules/consistent-empty-array-spread.md

@@ -0,0 +1,42 @@
+# Prefer consistent types when spreading a ternary in an array literal
+
+💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs-eslintconfigjs).
+
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
+<!-- end auto-generated rule header -->
+<!-- Do not manually modify this header. Run: `npm run fix:eslint-docs` -->
+
+When spreading a ternary in an array, we can use both `[]` and `''` as fallbacks, but it's better to have consistent types in both branches.
+
+## Fail
+
+```js
+const array = [
+	a,
+	...(foo ? [b, c] : ''),
+];
+```
+
+```js
+const array = [
+	a,
+	...(foo ? 'bc' : []),
+];
+```
+
+## Pass
+
+```js
+const array = [
+	a,
+	...(foo ? [b, c] : []),
+];
+```
+
+```js
+const array = [
+	a,
+	...(foo ? 'bc' : ''),
+];
+```

docs/rules/no-invalid-fetch-options.md

@@ -0,0 +1,44 @@
+# Disallow invalid options in `fetch()` and `new Request()`
+
+💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs-eslintconfigjs).
+
+<!-- end auto-generated rule header -->
+<!-- Do not manually modify this header. Run: `npm run fix:eslint-docs` -->
+
+[`fetch()`](https://developer.mozilla.org/en-US/docs/Web/API/fetch) throws a `TypeError` when the method is `GET` or `HEAD` and a body is provided.
+
+## Fail
+
+```js
+const response = await fetch('/', {body: 'foo=bar'});
+```
+
+```js
+const request = new Request('/', {body: 'foo=bar'});
+```
+
+```js
+const response = await fetch('/', {method: 'GET', body: 'foo=bar'});
+```
+
+```js
+const request = new Request('/', {method: 'GET', body: 'foo=bar'});
+```
+
+## Pass
+
+```js
+const response = await fetch('/', {method: 'HEAD'});
+```
+
+```js
+const request = new Request('/', {method: 'HEAD'});
+```
+
+```js
+const response = await fetch('/', {method: 'POST', body: 'foo=bar'});
+```
+
+```js
+const request = new Request('/', {method: 'POST', body: 'foo=bar'});
+```

docs/rules/no-length-as-slice-end.md

@@ -0,0 +1,30 @@
+# Disallow using `.length` as the `end` argument of `{Array,String,TypedArray}#slice()`
+
+💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs-eslintconfigjs).
+
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
+<!-- end auto-generated rule header -->
+<!-- Do not manually modify this header. Run: `npm run fix:eslint-docs` -->
+
+When calling `{String,Array,TypedArray}#slice(start, end)`, omitting the `end` argument defaults it to the object's `.length`. Passing it explicitly is unnecessary.
+
+## Fail
+
+```js
+const foo = string.slice(1, string.length);
+```
+
+```js
+const foo = array.slice(1, array.length);
+```
+
+## Pass
+
+```js
+const foo = string.slice(1);
+```
+
+```js
+const foo = bar.slice(1, baz.length);
+```

docs/rules/no-negation-in-equality-check.md

@@ -0,0 +1,30 @@
+# Disallow negated expression in equality check
+
+💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs-eslintconfigjs).
+
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+
+<!-- end auto-generated rule header -->
+<!-- Do not manually modify this header. Run: `npm run fix:eslint-docs` -->
+
+Using a negated expression in equality check is most likely a mistake.
+
+## Fail
+
+```js
+if (!foo === bar) {}
+```
+
+```js
+if (!foo !== bar) {}
+```
+
+## Pass
+
+```js
+if (foo !== bar) {}
+```
+
+```js
+if (!(foo === bar)) {}
+```

docs/rules/prefer-array-find.md

@@ -17,10 +17,18 @@ This rule is fixable unless default values are used in declaration or assignment
 const item = array.filter(x => isUnicorn(x))[0];
 ```
 
+```js
+const item = array.filter(x => isUnicorn(x)).at(-1);
+```
+
 ```js
 const item = array.filter(x => isUnicorn(x)).shift();
 ```
 
+```js
+const item = array.filter(x => isUnicorn(x)).pop();
+```
+
 ```js
 const [item] = array.filter(x => isUnicorn(x));
 ```
@@ -50,25 +58,18 @@ Type: `object`
 ### checkFromLast
 
 Type: `boolean`\
-Default: `false`
+Default: `true`
 
-Pass `checkFromLast: true` to check cases searching from last.
+Pass `checkFromLast: false` to disable check cases searching from last.
 
-#### Fail
+#### Pass
 
 ```js
-// eslint unicorn/prefer-array-find: ["error", {"checkFromLast": true}]
+// eslint unicorn/prefer-array-find: ["error", {"checkFromLast": false}]
 const item = array.filter(x => isUnicorn(x)).at(-1);
 ```
 
 ```js
-// eslint unicorn/prefer-array-find: ["error", {"checkFromLast": true}]
+// eslint unicorn/prefer-array-find: ["error", {"checkFromLast": false}]
 const item = array.filter(x => isUnicorn(x)).pop();
 ```
-
-#### Pass
-
-```js
-// eslint unicorn/prefer-array-find: ["error", {"checkFromLast": true}]
-const item = array.findLast(x => isUnicorn(x));
-```