Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown prop smooth #99

Closed
iduuck opened this issue Jul 5, 2016 · 5 comments
Closed

Unknown prop smooth #99

iduuck opened this issue Jul 5, 2016 · 5 comments

Comments

@iduuck
Copy link

iduuck commented Jul 5, 2016

There is something happening with the <Link /> tag for me. What is this causing? Without the smooth attribute, the scroll isn't happening .. well, smooth...

warning.js:44 Warning: Unknown prop `smooth` on <a> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
@fisshy
Copy link
Owner

fisshy commented Jul 5, 2016

What version do you use? It's an option to use animated scrolling or just scrolling.

@iduuck
Copy link
Author

iduuck commented Jul 5, 2016

@fisshy Thanks for the quick reply. I just installed it and I am using the (almost) latest version - 1.0.19.

This is how I just included it into my project:

<Link to="HomeGraph" smooth={true}>
  <div className={styles.icon}>
    <span>Content here</span>
  </div>
</Link>

@iduuck
Copy link
Author

iduuck commented Jul 5, 2016

I assume this is happening, because you are inheriting all props that the <Link /> component received into the <a> element and this is not a supported one for this.

@iduuck
Copy link
Author

iduuck commented Jul 5, 2016

You can have a look at this (I was using the simple frontend-boilerplate from @tj). So just check it out.

@fisshy
Copy link
Owner

fisshy commented Jul 5, 2016

No problem, just install the latest v1.0.20. I actually fucked up the last publish I did so I had to republish it. It should fix your problems :)

@fisshy fisshy closed this as completed Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants