Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup #15

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Code Cleanup #15

wants to merge 8 commits into from

Conversation

tcyrus
Copy link

@tcyrus tcyrus commented Jan 19, 2020

No description provided.

@MCTaylor17
Copy link
Collaborator

Hi @tcyrus and thanks for contributing to the project.

I thought it might be helpful to provide some context before discussing the updates. This project is a fork of a fork of ghost-on-heroku repo. The original has had minor changes to the documentation as early as 12 months ago, although I don't see any substantial changes to the codebase since Nov 2017.

This means there are a number of opportunities for modernization as I'm sure you've noticed. It also means there are two main approaches to this type of work:

  1. update here and send PR upstream
  2. update there and merge updates downstream

Perhaps @bmann has an opinion on how best to manage this type of decision on an open source project?

bin/create-config Outdated Show resolved Hide resolved
server.js Show resolved Hide resolved
@bmann
Copy link
Member

bmann commented Jan 23, 2020

Upstream is unmaintained. We’ll continue to maintain this as we use it ourselves to run our blog and use it as a demo of our Fission IPFS Heroku add on.

@MCTaylor17 thanks for the PR review! Will get rest of team to look as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants