Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Qualify Plugin use in register_plugin! macro #2

Merged
merged 1 commit into from Oct 23, 2023

Conversation

matheus23
Copy link
Member

I didn't test this yet. I literally edited this in the github interface 馃槄 (after locally noticing that the macro wouldn't work without an import).

Just noticed that there was another identifier that's probably better qualified in the macro.

鉁岋笍

Signed-off-by: Philipp Kr眉ger <philipp.krueger1@gmail.com>
@matheus23 matheus23 self-assigned this Oct 11, 2023
Copy link

@QuinnWilton QuinnWilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@QuinnWilton QuinnWilton merged commit 16e5565 into quinn-wip-rework Oct 23, 2023
2 of 7 checks passed
@matheus23 matheus23 deleted the matheus23/qualfy-plugin-macro branch October 23, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants