Use Fission Builders for the yaml parsing #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinvaneyk
force-pushed
the
fission-builder
branch
from
1825e81
to
c065c4d
Compare
This was referenced Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, users had to manually parse yaml's to semi-unreadable json's before submitting the function. This is annoying and seems to cause some confusing for new users.
This PR resolves these issues, by automating the parsing/transformation step using a Fission Builder. The user can create a workflow simply using the yaml workflow definition as the source. This source is passed to a Fission Builder for Fission Workflows, which generates the corresponding json.
This PR will make Fission Workflows depend on any Fission version which includes this fission/fission#397 -- which contains some related bug fixes in Fission.
Flyby:
wfcli parse <file>to output generated json over stdout.Fixes #60 #28 #72