Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event.delete permission #2884

Closed
fragsalat opened this issue Nov 29, 2023 · 1 comment · Fixed by #2885
Closed

Remove event.delete permission #2884

fragsalat opened this issue Nov 29, 2023 · 1 comment · Fixed by #2885

Comments

@fragsalat
Copy link

Is your feature request related to a problem? Please describe.
Our kubernetes clusters are quite restricted in terms of permissions and therefore it is for tracability reasons not allowed to delete events. fission seem to request the events.delete permission in two places, namely for the executor and keda linked below.
https://github.com/fission/fission/blob/main/charts/fission-all/templates/_fission-kubernetes-roles.tpl#L77
https://github.com/fission/fission/blob/main/charts/fission-all/templates/_fission-kubernetes-roles.tpl#L206

Describe the solution you'd like
As I could not find the reason in the code the delete permission is requested, I would like to get this removed. Therefore the events permission should be separated from the pods, services etc to not include the delete permission.

Describe alternatives you've considered
Alternatively the delete permission could be made optional and the code follows this similar to the executor.serviceAccountCheck.enabled could help, but as of now I would not know which part of the code tries to delete events.

Additional context

@fragsalat
Copy link
Author

fragsalat commented Nov 30, 2023

Wow, thank you a lot for the fast reaction and change <3!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant