Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Teacher and PR roles to badge checking #378

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Add Teacher and PR roles to badge checking #378

merged 1 commit into from
Sep 17, 2022

Conversation

tenhobi
Copy link
Member

@tenhobi tenhobi commented Sep 16, 2022 •
edited

Fixes a scenario when someone has only a Teacher, PR, etc. role and not a Staff role (KOS...).

@tenhobi
Copy link
Member Author

tenhobi commented Sep 16, 2022

Maybe we can add other roles as well? dunno

@tenhobi tenhobi requested a review from ostorc September 16, 2022 14:57
stepech
stepech approved these changes Sep 17, 2022
View reviewed changes
Copy link
Contributor

@stepech stepech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tenhobi tenhobi merged commit 801d710 into develop Sep 17, 2022
@tenhobi tenhobi deleted the fix/triggerroles branch September 17, 2022 13:34
@tenhobi tenhobi mentioned this pull request Sep 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepech stepech stepech approved these changes

@ostorc ostorc Awaiting requested review from ostorc

Assignees
No one assigned
Labels
release: fixed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tenhobi @stepech