Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the software options dictionary to make it more user friendly #260

Closed
tyronerees opened this issue Sep 27, 2019 · 3 comments · Fixed by #306
Closed

Refactor the software options dictionary to make it more user friendly #260

tyronerees opened this issue Sep 27, 2019 · 3 comments · Fixed by #306
Assignees

Comments

@tyronerees
Copy link
Member

tyronerees commented Sep 27, 2019

The current method of defining options is both complicated for the user and hard to maintain.

Options should be controlled in a single place so that setting an option is consistent, with priority:

  1. Values set in the example script.
  2. Values set in the options file.
  3. Values set as a default programmatically.

Options should also be able to be set easily, and have clearly defined default values.

@tyronerees
Copy link
Member Author

related to #231?

@AndrewLister-STFC
Copy link
Contributor

This issue needs rewording as per our discussion last week

@AndrewLister-STFC AndrewLister-STFC changed the title User interface proposal Refactor the software options dictionary to make it more user friendly Nov 18, 2019
@AndrewLister-STFC AndrewLister-STFC moved this from To do to In progress in ALC Sprint #3 Nov 18, 2019
@AndrewLister-STFC
Copy link
Contributor

AndrewLister-STFC commented Nov 18, 2019

I think switching from json to configparser (.ini) compatible files would be good.

It has less clutter (like the brackets in json), supports comments, and looks a bit more presentable.

In my first draft of this, I'll use config parser, but I can change it if people prefer json

AndrewLister-STFC added a commit that referenced this issue Nov 20, 2019
AndrewLister-STFC added a commit that referenced this issue Nov 20, 2019
@wathen wathen moved this from In progress to Review in progress in ALC Sprint #3 Nov 26, 2019
AndrewLister-STFC added a commit that referenced this issue Nov 27, 2019
@wathen wathen moved this from Review in progress to Reviewer approved in ALC Sprint #3 Nov 28, 2019
ALC Sprint #3 automation moved this from Reviewer approved to Done Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
ALC Sprint #3
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants