Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mistune bump from 0.8.4 to 2.x in /docs #1057

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 29, 2022

Bumps mistune from 0.8.4 to 2.0.3.

Release notes

Sourced from mistune's releases.

Version 2.0.2

Fix escape_url via lepture/mistune#295

Version 2.0.1

Fix XSS for image link syntax.

Version 2.0.0

First release of Mistune v2.

Version 2.0.0 RC1

In this release, we have a Security Fix for harmful links.

Version 2.0.0 Alpha 1

This is the first release of v2. An alpha version for users to have a preview of the new mistune.

Changelog

Sourced from mistune's changelog.

Changelog

Here is the full history of mistune v2.

Version 2.0.4


Released on Jul 15, 2022
  • Fix url plugin in <a> tag
  • Fix * formatting

Version 2.0.3

Released on Jun 27, 2022

Version 2.0.2


Released on Jan 14, 2022

Fix escape_url

Version 2.0.1

Released on Dec 30, 2021

XSS fix for image link syntax.

Version 2.0.0


Released on Dec 5, 2021

This is the first non-alpha release of mistune v2.

Version 2.0.0rc1

Released on Feb 16, 2021

Version 2.0.0a6


</tr></table> 

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [mistune](https://github.com/lepture/mistune) from 0.8.4 to 2.0.3.
- [Release notes](https://github.com/lepture/mistune/releases)
- [Changelog](https://github.com/lepture/mistune/blob/master/docs/changes.rst)
- [Commits](lepture/mistune@v0.8.4...v2.0.3)

---
updated-dependencies:
- dependency-name: mistune
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 29, 2022
@coveralls
Copy link
Collaborator

coveralls commented Jul 29, 2022

Coverage Status

Coverage decreased (-0.02%) to 86.316% when pulling 58f4f0c on dependabot/pip/docs/mistune-2.0.3 into 9a27120 on master.

@AndrewLister-STFC
Copy link
Contributor

Some notes from digging into this:

  • We have mistune as a secondary dependency of m2r2.
  • Currently m2r2 is built on mistune 0.8.4.
  • Mistune 2.x includes a large refactor that changes most api calls.
  • The maintainers of m2r2 are aware that this is an issue but don't necessarily have the time to upgrade at the moment.

See here for more details: www.github.com/CrossNox/m2r2/issues/47

@AndrewLister-STFC
Copy link
Contributor

We could consider switching to the linked https://sphinx-mdinclude.readthedocs.io/en/latest/ although I'm not sure how much that differs.

@AndrewLister-STFC AndrewLister-STFC changed the title Bump mistune from 0.8.4 to 2.0.3 in /docs Enable mistune bump from 0.8.4 to 2.x in /docs Sep 28, 2022
@AndrewLister-STFC AndrewLister-STFC self-assigned this Sep 28, 2022
@github-actions
Copy link

github-actions bot commented Sep 28, 2022

Unit & System Test Results

    4 files  ±0      4 suites  ±0   7m 11s ⏱️ - 3m 50s
360 tests ±0  352 ✔️ ±0    8 💤 ±0  0 ±0 
688 runs  ±0  639 ✔️ ±0  49 💤 ±0  0 ±0 

Results for commit 58f4f0c. ± Comparison against base commit 9a27120.

♻️ This comment has been updated with latest results.

Copy link
Member

@tyronerees tyronerees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding a solution to this. Markdown pages in docs look good. Although the new package is smaller than m2r2, it seems much preferable to having an unsupported dependency.

@tyronerees tyronerees merged commit c535470 into master Sep 28, 2022
@dependabot dependabot bot deleted the dependabot/pip/docs/mistune-2.0.3 branch September 28, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants