Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto display results optional #1093

Merged
merged 6 commits into from
Dec 16, 2022

Conversation

Shanrahan16
Copy link
Contributor

Description of Work

Fixes #474

Testing Instructions

  1. Should open browser by default.
  2. Should not open browser if FitBenchmarking is run with argument --dont_open_browser
  3. Should open browser if FitBenchmarking is run with argument --results_browser
  4. Should not open browser if .ini file contains results_browser: no
  5. Should open browser if .ini file contains results_browser: yes

Function: Does the change do what it's supposed to?

Tests: Does it pass? Is there adequate coverage for new code?

Style: Is the coding style consistent? Is anything overly confusing?

Documentation: Is there a suitable change to documentation for this change?
I will update the options table on the read the docs website once we have confirmed the names of the options

@coveralls
Copy link
Collaborator

coveralls commented Nov 25, 2022

Coverage Status

Coverage decreased (-0.2%) to 85.593% when pulling 101f74b on #474_auto_display_results_option into 3fa74ab on master.

@Shanrahan16 Shanrahan16 self-assigned this Nov 25, 2022
@github-actions
Copy link

github-actions bot commented Nov 25, 2022

Unit & System Test Results

    4 files  ±0      4 suites  ±0   7m 5s ⏱️ +6s
360 tests ±0  352 ✔️ ±0    8 💤 ±0  0 ±0 
688 runs  ±0  638 ✔️ ±0  50 💤 ±0  0 ±0 

Results for commit 6f17761. ± Comparison against base commit 64a2d1f.

♻️ This comment has been updated with latest results.

fitbenchmarking/cli/main.py Outdated Show resolved Hide resolved
fitbenchmarking/cli/main.py Outdated Show resolved Hide resolved
@AndrewLister-STFC AndrewLister-STFC merged commit af56057 into master Dec 16, 2022
@AndrewLister-STFC AndrewLister-STFC deleted the #474_auto_display_results_option branch December 16, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make auto display results optional
3 participants