New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Mantid Jacobians and created a Mantid development parser #1231
Conversation
Unit & System Test Results 4 files ±0 4 suites ±0 5m 57s ⏱️ +5s Results for commit 3c602fa. ± Comparison against base commit fc83cde. This pull request removes 14 and adds 21 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 1 question about the cached jacobians, but I think that's it
Co-authored-by: Andrew Lister <48282025+AndrewLister-STFC@users.noreply.github.com>
All working now apart from that I can't use lru cache with BiComplex... will have to have a think about how best to do this. |
@AnthonyLim23 I think this is ready? Can you check my understanding is right on the docs update I added: https://fitbenchmarking--1231.org.readthedocs.build/en/1231/users/options/jacobian_option.html |
yep. Looks good to me. |
Description of work
This PR adds Jacobians to the mantid parsers. However, it does not work for multistart problems.
It also adds a new
mantiddev
parser, which removes the advantage from the mantid software when evaluating mantid functions. This does not remove the advantage from mantid jacobians.Fixes #1228
Testing Instructions
I can send some test problems that use both mantid and mantiddev. It also shows a comparison with nist problems and has similar order of results.
Checklist