Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parser for inputting sparse jacobian #1257

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from
Draft

Added parser for inputting sparse jacobian #1257

wants to merge 56 commits into from

Conversation

Letizia97
Copy link
Contributor

@Letizia97 Letizia97 commented Feb 26, 2024 •
edited

Description of work

Fixes #1208 .

Testing Instructions

Checklist

  • The title is of a format appropriate for a line in future release notes. - although we might change it after merging the other PRs into this.
  • I have added the appropriate tags to the PR.
  • My PR represents one logical piece of work. - again, after adding the other PRs , yes.
  • My PR fully fixes the issue linked. If new issues have been created, what are they? - I think this will be the case once the other PRs are added to this.
  • I have added the appropriate tests to cover code that has been added.
  • I have updated the documentation in the relevant places to cover the changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited

Unit & System Test Results

  4 files  ± 0    4 suites  ±0   6m 41s ⏱️ ±0s
494 tests +15  486 ✅ +15   8 💤 ±0  0 ❌ ±0 
936 runs  +24  881 ✅ +23  55 💤 +1  0 ❌ ±0 

Results for commit 9dc08e2. ± Comparison against base commit 10d5107.

♻️ This comment has been updated with latest results.

@coveralls
Copy link
Collaborator

coveralls commented Feb 26, 2024 •
edited

Coverage Status

coverage: 91.009% (+0.1%) from 90.888%
when pulling 9dc08e2 on 1208-Sparse_jacobian
into 10d5107 on master.

@Letizia97 Letizia97 force-pushed the 1208-Sparse_jacobian branch 3 times, most recently from 0bc48fa to b3bc8fb Compare March 12, 2024 17:17
@Letizia97 Letizia97 force-pushed the 1208-Sparse_jacobian branch 2 times, most recently from 43a994d to b0e5eed Compare March 15, 2024 17:46
AndrewLister-STFC
AndrewLister-STFC requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@AndrewLister-STFC AndrewLister-STFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some very minor things from me on this

docs/source/users/problem_definition_files/native.rst Outdated Show resolved Hide resolved
fitbenchmarking/parsing/tests/test_parsers.py Outdated Show resolved Hide resolved
fitbenchmarking/utils/exceptions.py Outdated Show resolved Hide resolved
Letizia97 and others added 5 commits April 10, 2024 09:49
@Letizia97 @AndrewLister-STFC
Update fitbenchmarking/utils/exceptions.py
527ab38 
Co-authored-by: Andrew Lister <48282025+AndrewLister-STFC@users.noreply.github.com>
@Letizia97
Update docs.
11ae675
@Letizia97
Fix docs.
ef2d884
@Letizia97
Refactor tests.
0cb8a1a
@Letizia97
Fix test.
474b1b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewLister-STFC AndrewLister-STFC Awaiting requested review from AndrewLister-STFC

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parser/file format for inputting a sparse jacobian
3 participants
@Letizia97 @coveralls @AndrewLister-STFC