Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added errorbars to the plots in the fitting report #1279

Merged
merged 3 commits into from
May 20, 2024

Conversation

RabiyaF
Copy link
Contributor

@RabiyaF RabiyaF commented May 2, 2024

Description of work

Fixes #1245

image image

Testing Instructions

  1. Run fitbenchmarking from the cli. Once benchmarking is complete, navigate to the fitting report pages and verify error bars are present in the plots.
  2. Run pytest fitbenchmarking/results_processing/tests/test_plots.py --test-type default to verify tests are passing.

Checklist

  • The title is of a format appropriate for a line in future release notes.
  • I have added the appropriate tags to the PR.
  • My PR represents one logical piece of work.
  • My PR fully fixes the issue linked. If new issues have been created, what are they?
  • I have added the appropriate tests to cover code that has been added.
  • I have updated the documentation in the relevant places to cover the changes.

@RabiyaF RabiyaF added the Enhancement New feature or request label May 2, 2024
@RabiyaF RabiyaF self-assigned this May 2, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 2, 2024

Coverage Status

coverage: 90.682% (-0.01%) from 90.694%
when pulling 00f0168 on RabiyaF:1245-error-bars
into 0b3ea8a on fitbenchmarking:master.

@RabiyaF RabiyaF added ignore-for-release Don't include this PR in release notes and removed Enhancement New feature or request labels May 13, 2024
Copy link
Contributor

@jess-farmer jess-farmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works as expected!

@jess-farmer jess-farmer merged commit cf9d1f1 into fitbenchmarking:master May 20, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Don't include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error bars
3 participants