Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed emissions display when not measured #1287

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

jess-farmer
Copy link
Contributor

@jess-farmer jess-farmer commented May 20, 2024

Description of work

Fixes #1221

Changes fitting report so that Emissions value is listed as 'N/A' when the emissions table option is not selected. I have also updated the options_template.ini so that the emissions table is not deactivated, as measuring emissions is no longer painfully slow.

Testing Instructions

  1. Run Fitbenchmarking without emissions table option, and check fitting report.

Checklist

  • The title is of a format appropriate for a line in future release notes.
  • I have added the appropriate tags to the PR.
  • My PR represents one logical piece of work.
  • My PR fully fixes the issue linked. If new issues have been created, what are they?
  • I have added the appropriate tests to cover code that has been added.
  • I have updated the documentation in the relevant places to cover the changes.

@jess-farmer jess-farmer added the pr-fix Tag PR as bug fix in notes label May 20, 2024
Copy link

github-actions bot commented May 20, 2024

Unit & System Test Results

  4 files  ±0    4 suites  ±0   6m 37s ⏱️ +9s
507 tests ±0  499 ✅ ±0   8 💤 ±0  0 ❌ ±0 
968 runs  ±0  914 ✅ ±0  54 💤 ±0  0 ❌ ±0 

Results for commit f30c652. ± Comparison against base commit cf9d1f1.

♻️ This comment has been updated with latest results.

@coveralls
Copy link
Collaborator

coveralls commented May 20, 2024

Coverage Status

coverage: 90.668% (-0.01%) from 90.682%
when pulling f30c652 on fix_emissions_display
into cf9d1f1 on master.

@RabiyaF RabiyaF self-requested a review May 24, 2024 00:49
Copy link
Contributor

@RabiyaF RabiyaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with and without the emissions tables and it works as expected 👍🏼

@RabiyaF RabiyaF merged commit 4e337ab into master May 24, 2024
10 of 11 checks passed
@RabiyaF RabiyaF deleted the fix_emissions_display branch May 24, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-fix Tag PR as bug fix in notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emissions listed as inf when not activated
3 participants