Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #235

Merged
merged 2 commits into from Sep 20, 2019
Merged

Update README.md #235

merged 2 commits into from Sep 20, 2019

Conversation

arm61
Copy link
Contributor

@arm61 arm61 commented Sep 16, 2019

Description of Work

Fixes #234

Testing Instructions

  1. try the new instructions on a macOS machine

@TOFarmer
Copy link
Contributor

New instructions appear to work fine for me.

I assume it is unrelated to this, but the Mantid example script seems to have some problems:

  • A large number of the fits fail despite apparently not iterating at all:
    Fit-[Warning] Fit status: Failed to converge after 0 iterations.
  • Fits with IkedaCarpenter function (which is neutron wavelength dependent) always reports that the wavelength can't be calculated, and that this can be solved by loading the appropriate instrument:
IFunction1D-[Warning] No sample set for instrument in workspace.
IFunction1D-[Warning] Can't calculate wavelength in IkedaCarpenter.
IFunction1D-[Warning] Default all wavelengths to one.
IFunction1D-[Warning] Solution is to load appropriate instrument into workspace.

I'll create a separate issue for this.

@TOFarmer
Copy link
Contributor

I'm assuming you just want one of us to test this, but I won't merge it just in case you are after both of us.

@arm61
Copy link
Contributor Author

arm61 commented Sep 20, 2019

I'm assuming you just want one of us to test this, but I won't merge it just in case you are after both of us.

Was just spreading the odds

@arm61 arm61 merged commit 56cdb82 into master Sep 20, 2019
@AndrewLister-STFC AndrewLister-STFC deleted the 234_fix_readme branch September 26, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README instructions doesn't work for macOS
2 participants