Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

228 make imports relative #237

Merged
merged 5 commits into from
Sep 19, 2019
Merged

228 make imports relative #237

merged 5 commits into from
Sep 19, 2019

Conversation

arm61
Copy link
Contributor

@arm61 arm61 commented Sep 16, 2019

Description of Work

Fixes #228

Testing Instructions

  1. Run nose tests

AndrewLister-STFC
AndrewLister-STFC reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@AndrewLister-STFC AndrewLister-STFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only 1 comment.

fitbenchmarking/parsing/tests/test_parse_sasview_data.py Outdated Show resolved Hide resolved
AndrewLister-STFC
AndrewLister-STFC approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@AndrewLister-STFC AndrewLister-STFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. You tagged the three of us, did you want all of us to look or was it just to get at least one...?

@arm61
Copy link
Contributor Author

arm61 commented Sep 19, 2019

Great. You tagged the three of us, did you want all of us to look or was it just to get at least one...?

Was spreading the odds.

@arm61 arm61 merged commit 2a961b2 into fitbenchmarking:master Sep 19, 2019
@arm61 arm61 deleted the 228_make_imports_relative branch September 19, 2019 09:13
@tyronerees tyronerees mentioned this pull request Sep 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewLister-STFC AndrewLister-STFC AndrewLister-STFC approved these changes

@Anders-Markvardsen Anders-Markvardsen Awaiting requested review from Anders-Markvardsen

@TOFarmer TOFarmer Awaiting requested review from TOFarmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In example scripts have all import at the top
2 participants
@arm61 @AndrewLister-STFC