New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #228: Fix missed relative imports, and some indents. #240
Conversation
This doesn't run for me -- I get
Running |
Talked wth Tyrone. Issues seem to come from package data in setup.py? |
In order to get tests passing (where the are .dat, .txt files) I added some stuff to the package data in the setup.py. This may be causing issues (that really travis should be catching but oh well :) ) |
My next task is adding the example scripts to the test suite for just this reason. |
@AndrewLister-STFC -- just to record what I told you earlier: I need As reported by @Anders-Markvardsen in #225 (comment), adding |
This is pretty closely related to #226 (in that thats where the fixes for the setup have been added) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty closely related to #226 (in that thats where the fixes for the setup have been added)
Yes -- this shouldn't hold up this PR. @AndrewLister-STFC -- could you resolve the merge conflicts? Then I'll give it another glance over and we can tick this one off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description of Work
Fixes #228
Updated imports that were missed in last PR for this issue.
Testing Instructions