-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving data sorting from plotting to data input #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked on simple_tests
and CUTEst
(all minimizers) and Neutron
(scipy
and mantid
), and no changes in the accuracy.
The times are around 50% quicker with sorted data, suggesting that the fitting routines sort the data first.
For some reason this change slowed things down quite a bit on my system. I didn’t have time to investigate, and won’t be able to follow until I’m back in a week. I’ll pass over reviewing duty to @AndrewLister-STFC so this doesn’t get held up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think indexing data_e might be dangerous as it could be None?
I'm going to check the timings that @tyronerees mentioned now.
I had a look on mine, and found that the branch gives timings which are similar but slower. |
Description of Work
Fixes part of #242
Moves data sorting out of
fitbenchmarking/fitting/plotting
tofitbenchmarking/parsing
so that the data is sorted once.Testing Instructions