Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide github.com from list #63

Closed
binarykitchen opened this issue Sep 19, 2013 · 13 comments · Fixed by #67
Closed

Hide github.com from list #63

binarykitchen opened this issue Sep 19, 2013 · 13 comments · Fixed by #67

Comments

@binarykitchen
Copy link

Hello there

Your tool is neat, very handy! But can I somehow hide certain hosts from your config?

For example I have an entry for the host github.com so that I do not need to enter any passwords during git actions. In my ssh config I have this:

Host github.com
    HostName github.com
    Port 22
    IdentityFile ~/.ssh/id_rsa
    User xxx

How can I hide this within Shuttle?

@samface
Copy link

samface commented Nov 18, 2013

+1 on this issue. One should atleast be able to disable the function that automatically adds hosts from the ssh config file.

@roxaloxa
Copy link

Agreed! Config file should just have a

"read_ssh_config": false

sort of deal. Would love this feature.

@binarykitchen
Copy link
Author

No @roxaloxa that's a bad idea. I want the ssh config to be read. Just want to be able to ignore single entries in it. Better have something like ignore_in_shuttle (the ssh config file is not a JSON)

@roxaloxa
Copy link

@binarykitchen Oh okay, good point. For me, my only entry is a git server, so that's why I wanted the whole thing gone. But yours makes more sense.

@binarykitchen
Copy link
Author

@roxaloxa Exactly. Peace :)

@samface
Copy link

samface commented Nov 20, 2013

@binarykitchen Why would it be a bad idea? Noone suggested that the feature would be to prevent anyone from having the ssh config file read, all I was suggesting was the OPTION to not to. I'd like that feature and I'd like it set to not automatically add anything from any of my personal configuration files by default. Forcing such things on people or assuming without asking that such things are up for grabs to be used for something entirely different than what was intended, now THAT is a bad idea.

For those of you who do want the ssh config file to be read and merged into your Shuttle configuration, you got your wish and I'm happy for you. I hope you don't mind me suggesting this feature to be turned off by default. The idea to enhance the ssh config reading feature with the option to filter out specific entries is a good one, but not a solution for everyone.

@binarykitchen
Copy link
Author

@samface I understand. Sure, that's fine if there is an option for not adding anything from any personal config files. I have no reason to be against it. But I am not so sure to set a default for this one. Lots of my colleague hackers put dozens of servers in their config in .ssh/config ... so we should check first what the majority is.

Anyway, this one ticket of mine has the title Hide github.com from list. All I am asking here is for an option to ignore a single entry from .ssh/config and then I will shut up :)

@samface
Copy link

samface commented Nov 21, 2013

@binarykitchen I don't agree that it is an issue of what suits the majority the most. It's more like an issue of personal integrity for me. Like, the majority has facebook, but would that make it okay to automatically register everyone on facebook without asking first? I don't think so, just like I don't think it's ok when applications read my personal configuration files on my harddrive without asking me first.

@binarykitchen
Copy link
Author

@samface I agree with you 200% on that Facebook example. But .ssh/config? That's a wide spread Unix standard. Bash shell scripts never ask you for accessing .ssh/config. You can ssh anything right away. It would deteriorate usability if it asked for access. Same goes with Shuttle I guess. Shuttle is not a sharing platform like FB and stays local. Hence I am not worried about Shuttle.

I think that's a decision up to the makers of Shuttle. Personal Integrity VS Usability. I was happy to see Shuttle is listing all my servers asap without any further hassle.

If integrity is still important for some, how about asking for access to .ssh/config during the installation process? Just an idea. That would be ok for me. Better than experimenting with Shuttle's config.

Anyway, we're off-topic again. This integrity discussion should go in a new ticket. Again, all I am asking for is a new option to ignore a single entry from .ssh/config, amen.

@samface
Copy link

samface commented Nov 21, 2013

It's a wide spread Unix standard to keep personal and private stuff in .ssh, such as SSH-keys, which domains you trust, etc. That should NEVER be anyone but the authorized logged in user to decide who and what gets access to. You talk like hidden directories in the personal home folder would be public domain or something.

@fitztrev
Copy link
Owner

This has been merged. I'll write documentation and package a new release hopefully tomorrow.

In short, the following options will be available for accomplishing what has been discussed:

Disable all ~/.ssh/config entries:

"show_ssh_config_hosts": false,

Disable specific hosts:

"ssh_config_ignore_hosts": ["github.com", "git.example.com"],

Disable hosts that contain a keyword:

"ssh_config_ignore_keywords": ["git"],

Thank you to @mpdavis.

@binarykitchen
Copy link
Author

Thanks so much!

@samface
Copy link

samface commented Nov 27, 2013

Awesome! Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants