Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uml] Scripts for rendering images files from _plantuml_ files #10

Merged
merged 5 commits into from
Sep 1, 2021
Merged

[uml] Scripts for rendering images files from _plantuml_ files #10

merged 5 commits into from
Sep 1, 2021

Conversation

diegosanchez
Copy link
Member

@seblaz

Te parece mezclar esto?

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #10 (675ef14) into master (4596b10) will increase coverage by 18.46%.
The diff coverage is 100.00%.

❗ Current head 675ef14 differs from pull request most recent head 9ba04fd. Consider uploading reports for the commit 9ba04fd to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master      #10       +/-   ##
=============================================
+ Coverage     20.00%   38.46%   +18.46%     
- Complexity        2        5        +3     
=============================================
  Files             4        5        +1     
  Lines            20       26        +6     
=============================================
+ Hits              4       10        +6     
  Misses           16       16
Impacted Files Coverage Δ
src/main/java/edu/fiuba/algo3/modelo/Localize.java 100.00% <100.00%> (ø)
src/main/java/edu/fiuba/algo3/modelo/Message.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4596b10...9ba04fd. Read the comment docs.

seblaz
seblaz reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@seblaz seblaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buen trabajo! Dejo algunos comentarios

docs/PLANTUML.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/PLANTUML.md Outdated Show resolved Hide resolved
docs/PLANTUML.md Outdated Show resolved Hide resolved
scripts/render_diagrams.sh Outdated Show resolved Hide resolved
docs/PLANTUML.md Outdated Show resolved Hide resolved
docs/PLANTUML.md Outdated Show resolved Hide resolved
docs/PLANTUML.md Outdated Show resolved Hide resolved
docs/PLANTUML.md Outdated Show resolved Hide resolved
docs/PLANTUML.md Outdated Show resolved Hide resolved
@diegosanchez
Moving _Diagramas_ section outside README.md
e5df1b4
@diegosanchez
Script updated.
38e69c8 
It will clean up the _diagrams_ directory removing the old `*.png` files.
@diegosanchez
Copy link
Member Author

@seblaz y @tomasBustamante

Están todos los comentarios. Si ya está, hagan el aprueben y lo mezclo.

@tomasBustamante tomasBustamante self-assigned this Sep 1, 2021
seblaz
seblaz reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@seblaz seblaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gran trabajo! Solo dos comentarios pequeños de la doc para que quede igual que el resto

docs/Desarrollo.md
@@ -9,6 +9,10 @@ Existen distintas maneras de configurar el ambiente de desarrollo:
- [Nativo](./Nativo.md)
- [Docker](./Docker.md)

### Diagramas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se puede poner solo dos #? Como para que quede con el mismo tamaño que el resto de los títulos

docs/PlantUML.md
Comment on lines +24 to +26
```bash
scripts/render_diagrams.sh
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se puede agregar un $ al principio? Solo para que quede igual que otros ejemplos del readme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se puede agregar un $ al principio? Solo para que quede igual que otros ejemplos del readme

Me siento discriminado como usuario de zsh XD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jajaj podemos cambiarlo! Pero habría que hacerlo con todos

@diegosanchez diegosanchez merged commit ea2a5d2 into master Sep 1, 2021
@diegosanchez diegosanchez deleted the tools/plantUml branch September 1, 2021 00:48
@diegosanchez diegosanchez mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasBustamante tomasBustamante tomasBustamante approved these changes

@seblaz seblaz seblaz left review comments

Assignees

@tomasBustamante tomasBustamante

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diegosanchez @codecov-commenter @tomasBustamante @seblaz