Skip to content

Commit

Permalink
avoid calling fs.writeFileSync with numeric data
Browse files Browse the repository at this point in the history
  • Loading branch information
fivdi committed Apr 23, 2020
1 parent 0c69b1e commit 4d78239
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions test/activeLow.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ describe('activeLow', () => {


it('is active high', () => {
MockLinux.writeActiveLow(pin, 1);
MockLinux.writeActiveLow(pin, '1');
const actual = gpio.activeLow();
assert.deepEqual(actual, true);
});

it('is active low', () => {
MockLinux.writeActiveLow(pin, 0);
MockLinux.writeActiveLow(pin, '0');
const actual = gpio.activeLow();
assert.deepEqual(actual, false);
});
Expand Down
8 changes: 4 additions & 4 deletions test/read.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('read', () => {

it('reads high', (done) => {
const expected = 1;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
gpio.read((err, actual) => {
assert.deepEqual(actual, expected);
done();
Expand All @@ -32,7 +32,7 @@ describe('read', () => {

it('reads low', (done) => {
const expected = 0;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
gpio.read((err, actual) => {
assert.deepEqual(actual, expected);
done();
Expand Down Expand Up @@ -74,14 +74,14 @@ describe('read Promise', () => {

it('reads high', () => {
const expected = 1;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
return gpio.read()
.then(actual => TestHelper.shouldEventuallyEqual(actual, expected));
});

it('reads low', () => {
const expected = 0;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
return gpio.read()
.then(actual => TestHelper.shouldEventuallyEqual(actual, expected));
});
Expand Down
4 changes: 2 additions & 2 deletions test/readSync.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ describe('readSync', () => {

it('reads high', () => {
const expected = 1;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
const actual = gpio.readSync();
assert.deepEqual(actual, expected);
});

it('reads low', () => {
const expected = 0;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
const actual = gpio.readSync();
assert.deepEqual(actual, expected);
});
Expand Down
4 changes: 2 additions & 2 deletions test/typedefinition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ describe('definition', () => {
assert.deepEqual(actual, expected);
done();
});
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
});

afterEach(() => {
gpio.unexport();
MockLinux.restore();
});
});
});
6 changes: 3 additions & 3 deletions test/watch-callbacks.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe('watch callbacks', () => {
gpio = new Gpio(pin, 'in', 'both');

const expected = 0;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
gpio.watch((err, actual) => {
assert.deepEqual(actual, expected);
done();
Expand All @@ -49,7 +49,7 @@ describe('watch callbacks', () => {
gpio = new Gpio(pin, 'in', 'both', {debounceTimeout: 10});

const expected = 1;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
gpio.watch((err, actual) => {
assert.deepEqual(actual, expected);
done();
Expand All @@ -60,7 +60,7 @@ describe('watch callbacks', () => {
gpio = new Gpio(pin, 'in', 'both', {debounceTimeout: 10});

const expected = 0;
MockLinux.write(pin, expected);
MockLinux.write(pin, '' + expected);
gpio.watch((err, actual) => {
assert.deepEqual(actual, expected);
done();
Expand Down

0 comments on commit 4d78239

Please sign in to comment.