Fixed marvel.creators.findByName function

[kakakakakku]

Hi, I found that marvel.creators.findByName function doesn't work.

• Fetch by first name only : 🆖
• Fetch by first and middle name only : 🆖
• Fetch by first, middle, and last name : 🆗

Because, middleName and lastName are not allowed blank.

// debug code
console.log(response.statusCode); // 409
console.log(response.body); // { code: 409, status: 'lastName cannot be blank if it is set' }

After fixed

code

marvel.creators.findByName('austin')
  .then(console.log)
  .fail(console.error)
  .done();

marvel.creators.findByName('Goran', 'Sudzuka')
  .then(console.log)
  .fail(console.error)
  .done();

marvel.creators.findByName('Pat', 'Lee', '(X-Men/FF)')
  .then(console.log)
  .fail(console.error)
  .done();

result

{ data:
   [ { id: 2935,
       firstName: 'Austin',
       middleName: '',
       lastName: '',
       suffix: '',
       fullName: 'Austin',
       modified: '2007-01-02T00:00:00-0500',
       thumbnail: [Object],
       resourceURI: 'http://gateway.marvel.com/v1/public/creators/2935',
       comics: [Object],
       series: [Object],
       stories: [Object],
       events: [Object],
       urls: [Object] } ],
  meta: { offset: 0, limit: 20, total: 1, count: 1 } }
{ data:
   [ { id: 11479,
       firstName: 'Goran',
       middleName: 'Sudzuka',
       lastName: '',
       suffix: '',
       fullName: 'Goran Sudzuka',
       modified: '2011-10-03T17:17:54-0400',
       thumbnail: [Object],
       resourceURI: 'http://gateway.marvel.com/v1/public/creators/11479',
       comics: [Object],
       series: [Object],
       stories: [Object],
       events: [Object],
       urls: [Object] } ],
  meta: { offset: 0, limit: 20, total: 1, count: 1 } }
{ data:
   [ { id: 9215,
       firstName: 'Pat',
       middleName: 'Lee',
       lastName: '(X-Men/FF)',
       suffix: '',
       fullName: 'Pat Lee (X-Men/FF)',
       modified: '2007-01-02T00:00:00-0500',
       thumbnail: [Object],
       resourceURI: 'http://gateway.marvel.com/v1/public/creators/9215',
       comics: [Object],
       series: [Object],
       stories: [Object],
       events: [Object],
       urls: [Object] } ],
  meta: { offset: 0, limit: 20, total: 1, count: 1 } }

Fixed README.md

('austin', 'dave') and ('austin', 'dave', 'cam') parameters don't exist, so that fixed correct parameters.

Testing

➜  marvel-api git:(fix-creators) ✗ make test
  174 passing (454ms)

Thank you 👍

[fiveisprime]

This is an amazing pull request. Thank you so much!