Merge pull request #9 from fiverr/official_release

bump to 1.0.0 after adoption
fiverr · Apr 16, 2024 · e3e925a · e3e925a
2 parents 3ac8459 + 876c809
commit e3e925a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 22 deletions.
diff --git a/charts/karpenter_nodes/Chart.yaml b/charts/karpenter_nodes/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: karpenter_nodes
-version: 0.1.4
+version: 1.0.0
 description: A Helm chart for generating NodeClasses and NodePools for Karpenter
 maintainers:
   - name: nadavbuc
diff --git a/charts/karpenter_nodes/README.md b/charts/karpenter_nodes/README.md
@@ -91,7 +91,7 @@ Note - Most of the values can be overridden per nodegroup (If not specified, it
 | `nodegroups.{}.instances.*`    | Explicitly specify instances override, if using defaults specify `instances: {}` | `Map` | ✓ | ✓ |
 
 ### Headroom Configuration
-Headroom will create `pause` pods with requetss to just keep empty nodes up and ready for scheduling.<br> This is useful for scaling up quickly when needed.<br>
+Headroom will create `pause` pods with resources-requests to just keep free amount of resources up and ready for scheduling.<br> This is useful for scaling up quickly when needed.<br>
 The pods will be configured with ultra-low priority, and will be terminated and recreated on new nodes to free them up for usage if needed.
 |  Key Name                      | Description | Type | Optional? | Optional Per NodeGroup? |
 | ------------------------------ | ----------- | ---- | --------- | ----------------------- |

diff --git a/charts/karpenter_nodes/examples/nodegroups.yaml b/charts/karpenter_nodes/examples/nodegroups.yaml
@@ -4,8 +4,8 @@ nodeGroups:
     weight: 2
     instances:
       categories:
-      - m
-      - r
+        - m
+        - r
     capacitySpread:
       start: 1
       end: 5
@@ -18,8 +18,8 @@ nodeGroups:
     instances:
       minGeneration: 5
       categories:
-      - m
-      - r
+        - m
+        - r
       capacityType:
         - on-demand
     nodeClassRef:
@@ -28,20 +28,19 @@ nodeGroups:
     weight: 2
     instances:
       categories:
-      - m
-      - r
+        - m
+        - r
     capacitySpread:
       start: 1
       end: 5
-
   nodes-workers-c:
     nodeGroupLabel: nodes-workers
     capacitySpread:
       start: 1
       end: 5
     instances:
       categories:
-      - c
+        - c
     nodeClassRef:
       name: nodes-workers-amd64
   nodes-canary:
@@ -58,6 +57,9 @@ nodeGroups:
     instances:
       capacityType:
         - on-demand
+      cores:
+        - "8"
+        - "16"
     consolidationPolicy: "WhenEmpty"
     taints:
       - key: "dedicated"
@@ -79,6 +81,9 @@ nodeGroups:
       architecture: "multiarch"
       capacityType:
         - on-demand
+      minGeneration: 7
+      cores:
+        - "8"
     taints:
       - key: "dedicated"
         value: "ingress"

diff --git a/charts/karpenter_nodes/examples/output/output.yaml b/charts/karpenter_nodes/examples/output/output.yaml
@@ -1230,17 +1230,11 @@ spec:
         - key: "karpenter.k8s.aws/instance-cpu"
           operator: In
           values:
-          - "4"
           - "8"
-          - "12"
-          - "16"
-          - "24"
-          - "32"
-          - "48"
         - key: karpenter.k8s.aws/instance-generation
           operator: Gt
           values:
-          - "3"
+          - "6"
         - key: "topology.kubernetes.io/zone"
           operator: In
           values:
@@ -1342,13 +1336,8 @@ spec:
         - key: "karpenter.k8s.aws/instance-cpu"
           operator: In
           values:
-          - "4"
           - "8"
-          - "12"
           - "16"
-          - "24"
-          - "32"
-          - "48"
         - key: karpenter.k8s.aws/instance-generation
           operator: Gt
           values: