Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infra-k8s install script versions & architecture #168

Merged
merged 2 commits into from
May 15, 2024

Conversation

jarojasm95
Copy link
Member

No description provided.

Copy link

@nabil-khawaja-fivestars nabil-khawaja-fivestars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for putting this up, was gonna go ahead and do this after we made sure we got everything working properly. There was also something to change in the install-aladdin.sh script to update it to look at main instead of master on line 6.

Also not sure if we need to do any further check for the Mac case if there's an Intel chip vs Apple chip when we do the installs using

typeset url="https://dl.k8s.io/v${VERSION_KUBECTL}/kubernetes-client-darwin-amd64.tar.gz"

vs

typeset url="https://dl.k8s.io/v${VERSION_KUBECTL}/kubernetes-client-darwin-arm64.tar.gz"

and similar case for the helm install, but I think updating these versions for now may help with the aladdin --init defaulting back to the old values for now.

@jarojasm95 jarojasm95 changed the title Fix infra-k8s install script versions Fix infra-k8s install script versions & architecture May 15, 2024
@jarojasm95 jarojasm95 merged commit b9f1570 into main May 15, 2024
1 check failed
@jarojasm95 jarojasm95 deleted the fix-infra-install-versions branch May 15, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants