-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add year scrapped to readme #282
Comments
Any ideas how to do this the smart way? |
The readme currently reads:
The data comes from Marvel Wikia<http://marvel.wikia.com/Main_Page> and DC Wikia<http://dc.wikia.com/wiki/Main_Page>. Characters were scraped on August 24. Appearance counts were scraped on September 2. The month and year of the first issue each character appeared in was pulled on October 6.”
I would just add YYYY after the month to indicate when the data was pulled from the wikis. Ex:
“The data comes from Marvel Wikia<http://marvel.wikia.com/Main_Page> and DC Wikia<http://dc.wikia.com/wiki/Main_Page>. Characters were scraped on August 24, 2013. … Appearance counts were scraped on September 2, 2013. The month and year of the first issue each character appeared in was pulled on October 6, 2013.”
(I have no idea if 2013 is the right year BTW)
Thank you!
Megan (who is using this data set as an example in for a workshop)
From: Anatoli Babenia ***@***.***>
Sent: Wednesday, June 23, 2021 9:04 AM
To: fivethirtyeight/data ***@***.***>
Cc: O'Donnell, Megan N [LIB] ***@***.***>; Author ***@***.***>
Subject: Re: [fivethirtyeight/data] Please add year scrapped to readme (#282)
Any ideas how to do this the smart way?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#282 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB7INEPU4O6QK7VPRSKK2KLTUHSW3ANCNFSM47F3MWDQ>.
|
hey! It was 2014. Here's the story in question: https://fivethirtyeight.com/features/women-in-comic-books/ |
I made a guess based on GitHub's "last updated 7 years ago" note :-) |
So that's the README that needs a patch https://github.com/fivethirtyeight/data/tree/master/comic-characters I thought the request is to adjust all READMEs to contain some kind of machine readable tag with the date. |
Yes, sorry for the confusion. It's only the readme for the comic characters that needs a change. Sorry for the confusion, I forgot that it was a subset of the fivethirtyeight repository. |
OK, this should be fixed now! |
Please add the year the data originates from to the readme in order to easily date it. Thank you!
The text was updated successfully, but these errors were encountered: