Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add year scrapped to readme #282

Closed
m3gan0 opened this issue Jun 23, 2021 · 7 comments
Closed

Please add year scrapped to readme #282

m3gan0 opened this issue Jun 23, 2021 · 7 comments

Comments

@m3gan0
Copy link

m3gan0 commented Jun 23, 2021

Please add the year the data originates from to the readme in order to easily date it. Thank you!

@abitrolly
Copy link

Any ideas how to do this the smart way?

@m3gan0
Copy link
Author

m3gan0 commented Jun 23, 2021 via email

@walterhickey
Copy link
Contributor

hey! It was 2014. Here's the story in question: https://fivethirtyeight.com/features/women-in-comic-books/

@m3gan0
Copy link
Author

m3gan0 commented Jun 23, 2021

I made a guess based on GitHub's "last updated 7 years ago" note :-)

@abitrolly
Copy link

So that's the README that needs a patch https://github.com/fivethirtyeight/data/tree/master/comic-characters

I thought the request is to adjust all READMEs to contain some kind of machine readable tag with the date.

@m3gan0
Copy link
Author

m3gan0 commented Jun 24, 2021

Yes, sorry for the confusion. It's only the readme for the comic characters that needs a change. Sorry for the confusion, I forgot that it was a subset of the fivethirtyeight repository.

@Neil-Paine-1
Copy link
Contributor

OK, this should be fixed now!

@jayb jayb closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants