Feature/amazon ads #75
Conversation
fivetran-joemarkiewicz
added
type:enhancement
There was a problem hiding this comment.
@fivetran-catfritz this is looking great and all tests are passing on my end! I have just a few small change requests and comments below. Once those updates are applied and address, let me know and I can re-review!
Additionally, this is not from your PR, but I noticed the .DS_STORE file has been erroneously included in the root directory. This file is generated when creating the docs on a macOS computer. This is not needed and should be removed. Do you mind deleting this file in your PR and adding it to the .gitignore file. Thanks!
Let me know if you have any questions 😄
packages.yml
Outdated
| # - package: fivetran/amazon_ads | ||
| # version: [">=0.1.0", "<0.2.0"] | ||
| - git: https://github.com/fivetran/dbt_amazon_ads.git | ||
| revision: main | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Friendly reminder to switch before release 😄
There was a problem hiding this comment.
@fivetran-catfritz thanks so much for applying the changes I requested. The PR looks great and I only have one final suggestion to the README. Once that is applied we can go ahead and regen the docs (using our postgres integration tests).
Let's hold off on merging this until the Amazon Ads packages are officially released. Great job!!
…ad_reporting into feature/amazon-ads merge fix
integration_tests/dbt_project.yml
Outdated
| @@ -13,7 +13,8 @@ dispatch: | |||
| vars: | |||
|
|
|||
| apple_search_ads__using_search_terms: True | |||
| twitter_ads__using_keywords: False | |||
| twitter_ads__using_keywords: True | |||
There was a problem hiding this comment.
@fivetran-catfritz should this be switched?
There was a problem hiding this comment.
@fivetran-joemarkiewicz I did it so the docs would generate with the twitter ads keyword reports, but if they shouldn't be I'll put it back.
There was a problem hiding this comment.
I have changed this back!
fivetran-catfritz
removed
the
update_type:models
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
Amazon Ads has officially been released and added to Ad Reporting.
Amazon Ad data can now be rolled into the below models:
Documentation has been updated to include Amazon Ads information.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
May need to disable amazon ads models if not using.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
📦
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.