add reddit ads #83
add reddit ads #83
Conversation
fivetran-joemarkiewicz
added
the
type:enhancement
There was a problem hiding this comment.
@fivetran-reneeli A few quick suggestions, but I am unable to have this run successfully in my local environment. See my errors below. I believe there are additional updates that need to be made to this package in order to integrate Reddit Ads successfully into the roll up reports.
Can you make the proper updates to ensure this will run. Once the updates are applied you can mark this for re-review.
packages.yml
Outdated
| # - package: fivetran/reddit_ads | ||
| # version: [">=0.1.0", "<0.2.0"] |
There was a problem hiding this comment.
obligatory reminder to update before release.
There was a problem hiding this comment.
@fivetran-reneeli this looks great! Thanks for working so efficiently to get this integrated into the package! We can now kick off the releases for the upstream packages.
Let's hold off to cut this release until reddit ads and reddit ads source are live on the hub. We can sync during standup tomorrow.
Also a last note, don't forget to bump the version of the package in the README in Step 2.
packages.yml
Outdated
| - git: https://github.com/fivetran/dbt_reddit_ads.git | ||
| revision: main | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to switch before release
|
buildkite is failing on linked in versions, as expected |
|
@fivetran-reneeli can we switch back to the latest version of linkedin. I don't believe we will be able to cut the update before this release. |
Are you a current Fivetran customer?
Internal
What change(s) does this PR introduce?
Add in the reddit ads reports
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
馃拑
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.