Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinterest v0.8.0 #94

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Pinterest v0.8.0 #94

merged 7 commits into from
Jul 20, 2023

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Jul 14, 2023

PR Overview

This PR will address the following Issue/Feature:
Update pinterest package dependency version

This PR will result in the following new package version:

v1.5.0

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Update pinterest version in the packages.yml and documentation

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Will test once underlying pinterest package gets released, but right now you can switch it out with

  - git: https://github.com/fivetran/dbt_pinterest.git
    revision: feature/pinterest_v5_API_support
    warn-unpinned: false

Before marking this PR as "ready for review" the following have been applied:

  • [n/a] The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • [n/a] You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

Run with the above mentioned dependency

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • [n/a] DECISIONLOG updates have been updated (if applicable)
  • [n/a] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • [n/a] docs were regenerated (unless this PR does not include any code or yml updates)
    Wait until all packages deps updates are merged into the release branch

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli fivetran-reneeli self-assigned this Jul 14, 2023
@fivetran-reneeli fivetran-reneeli changed the base branch from main to release/v1.5.0 July 14, 2023 19:34
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli thanks for getting this started! I have a few comments before this is good to merge into the release branch. Let me know if you have questions. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
integration_tests/dbt_project.yml Show resolved Hide resolved
fivetran-reneeli and others added 2 commits July 14, 2023 16:01
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates. LGTM!

@fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-reneeli I realized the README also needs to be updated to reflect the new version of the Ad Package as well as the Pinterest Ads dependency version upgrades. Would you be able to make those changes and then feel free to merge this into the release branch.

Please hold off on merging the release branch as we are waiting on a number of other updates.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 837d5e9 into release/v1.5.0 Jul 20, 2023
1 check failed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the pinterest_v0.8.0 branch July 20, 2023 14:16
@fivetran-joemarkiewicz fivetran-joemarkiewicz mentioned this pull request Jul 20, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants