feature/amazon-ads-v0.2.0

[fivetran-catfritz]

PR Overview

This PR will address the following Issue/Feature:
Update amazon ads package dependency version

This PR will result in the following new package version:

v1.5.0

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Update amazon ads version in the packages.yml and documentation

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test (except for the known google ads issue)
• dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

none required

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• README updates have been applied (if applicable)
• DECISIONLOG updates have been updated (if applicable)
• Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)
  Wait until all packages deps updates are merged into the release branch

If you had to summarize this PR in an emoji, which would it be?

🚚

[fivetran-joemarkiewicz]

@fivetran-catfritz thanks for pushing these Amazon Ad updates along! This PR looks good to go!

One thing I noticed is that we are not testing Amazon Ads in our integration tests pipeline.

dbt_ad_reporting/.buildkite/scripts/run_models.sh

Lines 20 to 21 in 050495a

	dbt run --target "$db" --full-refresh --vars '{ad_reporting__linkedin_ads_enabled: false, ad_reporting__pinterest_ads_enabled: false, ad_reporting__tiktok_ads_enabled: false, ad_reporting__snapchat_ads_enabled: false, ad_reporting__apple_search_ads_enabled: false, ad_reporting__facebook_ads_enabled: false, ad_reporting__amazon_ads_enabled: false}'
	dbt test --target "$db" --vars '{ad_reporting__linkedin_ads_enabled: false, ad_reporting__pinterest_ads_enabled: false, ad_reporting__tiktok_ads_enabled: false, ad_reporting__snapchat_ads_enabled: false, ad_reporting__apple_search_ads_enabled: false, ad_reporting__facebook_ads_enabled: false, ad_reporting__amazon_ads_enabled: false}'

I tested locally and all checked out, but I do wonder what our approach should be when making updates to excluded models from the integration tests? We intentionally exclude them to improve the integration test timeline. But I do worry in the future if we accidentally introduce an issue because we weren't testing.

What are your thoughts on manually adding the package models we are updating, but then removing a packages models that are not being updated for Ad Reporting? My only concern is that I wouldn't want to remove a package like Google Ads or Facebook Ads as they are most popular and should always be tested.

Any thoughts?

[fivetran-joemarkiewicz]

Reminder to switch before merge.

[fivetran-catfritz]

What are your thoughts on manually adding the package models we are updating, but then removing a packages models that are not being updated for Ad Reporting? My only concern is that I wouldn't want to remove a package like Google Ads or Facebook Ads as they are most popular and should always be tested.

@fivetran-joemarkiewicz I think that would make sense and be doable. Maybe this can be something we update the PR checklist specifically for ad_reporting? Something like:

• Adjust run_models dbt run and dbt test variables to include:
  • This package = true
  • Google Ads and Facebook Ads = true
  • All other packages = false
    ?

[fivetran-joemarkiewicz]

What are your thoughts on manually adding the package models we are updating, but then removing a packages models that are not being updated for Ad Reporting? My only concern is that I wouldn't want to remove a package like Google Ads or Facebook Ads as they are most popular and should always be tested.

@fivetran-joemarkiewicz I think that would make sense and be doable. Maybe this can be something we update the PR checklist specifically for ad_reporting? Something like:

• Adjust run_models dbt run and dbt test variables to include:

  • This package = true
  • Google Ads and Facebook Ads = true
  • All other packages = false
    ?

I actually really like this idea! Would you be interested in incorporating a new entry like this into the maintainer PR template within this PR to be incorporated in the future?

[fivetran-joemarkiewicz]

@fivetran-catfritz FYI buildkite is now failing due to Pinterest Ads version dep out of range. This will be resolved once the Pinterest changes are live. Please feel comfortable merging to the release branch with the failed buildkite job. We will confirm all tests pass once all upstream package updates are live on the dbt hub and before merging the release branch to main.