Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation/basic-ad-update #31

Merged
merged 8 commits into from
Nov 8, 2023

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Nov 2, 2023

PR Overview

This PR will address the following Issue/Feature: #26 and #35

This PR will result in the following new package version: v0.7.1

This will not be a breaking change as this only updates documentation.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Documentation Updates

  • The prerequisite steps for generating the basic_ad pre-built report have been modified to reflect the current state of the Facebook Ads connector.
  • Adds the DECISIONLOG to clarify why there exist differences among aggregations across different grains.

Additional updates

  • This PR includes the addition of the auto releaser and 2nd reviewer github actions to be leveraged following merge to main.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • [n/a] dbt compile
  • [n/a] dbt run –full-refresh
  • [n/a] dbt run
  • [n/a] dbt test
  • [n/a] dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

In order to validate these steps I went through the creation of a new Facebook Ads connector facebook_ads_basic_ad_test and confirmed the basic_ad pre-built report is now synced by default and if you wish to enable/disable the table you will do so via the schema tab.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • [n/a] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • [n/a as no code or yml changes were applied] docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🏗️

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Nov 2, 2023
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-data-model-bot fivetran-data-model-bot requested review from a team, fivetran-jamie and fivetran-avinash and removed request for a team November 6, 2023 22:58
@fivetran-data-model-bot fivetran-data-model-bot requested review from a team and fivetran-reneeli and removed request for a team November 6, 2023 23:00
@fivetran-catfritz
Copy link
Contributor

@fivetran-joemarkiewicz Hey really really really sorry I accidentally committed to your branch... I undid it though so you can ignore.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-data-model-bot fivetran-data-model-bot requested review from a team and fivetran-avinash and removed request for a team November 7, 2023 22:03
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 3733960 into main Nov 8, 2023
3 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the documentation/basic-ad-update branch November 8, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants