Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/singular-tests-addition #116

Closed
wants to merge 5 commits into from

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature: No corresponding issue or feature

This PR will result in the following new package version: v1.6.0

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • It was observed that the fivetran_platform__audit_table model could potentially introduce duplicates for database like connectors. To address this issue, the join logic in the end model was adjusted to no longer be determined by date ranges and instead be defined via model generated indexes. This ensures true uniqueness in the end model.

Testing Updates

  • Addition of the tests/ folder which includes various custom validation tests to ensure the the output of the end models are matching our expectations.
    • These tests are disabled by default as they are not necessary to run after every execution of the models. If you would like to enabled these tests you may activate them by defining the fivetran_validation_tests_enabled variable as true.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

If you had to summarize this PR in an emoji, which would it be?

🖥️

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Mar 6, 2024
@fivetran-joemarkiewicz
Copy link
Contributor Author

The majority of these changes are included within PR #130. Therefore, I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant