Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/linkedin api updates 2023 #28

Merged
merged 19 commits into from
Mar 23, 2023

Conversation

fivetran-sheringuyen
Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen commented Feb 6, 2023

❗ ❗
We are currently waiting for data to verify the updates before merging and releasing the changes in this PR. If you are currently using our Linkedin Package and would like to test out this version of the Package, we would love to hear about your experience. Please feel free to comment below and let us know what your experience is!

For those interested, you can test out this version by adding the below in your packages.yml and temporarily comment out your current version of dbt_linkedin.

packages:
  - git: https://github.com/fivetran/dbt_linkedin.git
    revision: feature/linkedin-api-updates-2023
    warn-unpinned: false

❗ ❗

Are you a current Fivetran customer?

Fivetran employee 💃

What change(s) does this PR introduce?

🚨 Breaking Changes 🚨

Due to Linkedin Ads API change in January 2023, there have been updates in the Linkedin Ads Fivetran Connector and therefore, updates to this Linkedin package.

The following fields have been completely deprecated in the stg_linkedin_ads__creative_history model:

  • type
  • call_to_action_label_type
  • version_tag

Updates

  • linkedin_ads__creative_report now includes campaign.type as campaign_type as a proxy for the previously used creative.type field.
  • linkedin_ads__creative_report no longer includes the fields creative.version_tag, creative.type and creative.call_to_action_label_type.
  • linkedin_ads__creative_report now leverages report.creative_id instead of creative.creative_id.
  • linkedin_ads__campaign_report now leverages report.campaign_id instead of campaign.campaign_id.
  • linkedin_ads__url_report no longer includes the field creative.version_tag and now leverages report.creative_id instead of creative.creative_id.

Under the hood

  • integration_tests/seed/linkedin_creative_history_data has been updated to reflect new fields and deprecated fields updates
  • Legacy fields have been updated respectively in the connector and dbt_linkedin_source v0.7.0 includes modifications that could affect the below fields within the linkedin_ads__creative_history model:

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-sheringuyen
Copy link
Contributor Author

fivetran-sheringuyen commented Feb 6, 2023

To-do:

  • Docs to be generated before merge & release!

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-sheringuyen The changes look good; however, I will hold off on approving until we get confirmation from the product team that these are good to roll out.

Additionally, I had a few super minor comments to address in the meantime.

packages.yml Outdated Show resolved Hide resolved
integration_tests/dbt_project.yml Show resolved Hide resolved
Copy link

@Csgoodman Csgoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Very thorough change log :)

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! Thanks again @fivetran-sheringuyen

packages.yml Outdated Show resolved Hide resolved
@fivetran-sheringuyen fivetran-sheringuyen merged commit 581f10b into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants