Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/sales item account #114

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Bug/sales item account #114

merged 7 commits into from
Jan 22, 2024

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Jan 11, 2024

PR Overview

This PR will address the following Issue/Feature: #112

This PR will result in the following new package version:

  • v0.12.2
  • Non-breaking since we are correcting a coalesce.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

  • Updated model int_quickbooks__invoice_double_entry to account for the sales_item_account_id field from the invoice_lines source when determining the account_id associated with an invoice.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned.
  • All necessary documentation and version upgrades have been applied.
  • docs were regenerated (unless this PR does not include any code or yml updates).
  • BuildKite integration tests are passing.
  • Detailed validation steps have been provided below.

Detailed Validation

Please share any and all of your validation steps:

  • Validated live with customer's data.

If you had to summarize this PR in an emoji, which would it be?

🔢

@fivetran-catfritz fivetran-catfritz self-assigned this Jan 18, 2024
@fivetran-catfritz fivetran-catfritz linked an issue Jan 18, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one small comment to make an update in the CHANGELOG. Other than that, this looks good to me! Especially given the customer verifying the fix worked on their end, and that this addition is the last item in the coalesce. I don't foresee this have any impact on existing customers who were not previously impacted by the omittion.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-catfritz fivetran-catfritz merged commit f9f6d1c into main Jan 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Missing Account IDs for multiple transactions
3 participants