Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source relation fix #123

Merged
merged 12 commits into from
Apr 30, 2024
Merged

source relation fix #123

merged 12 commits into from
Apr 30, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Apr 24, 2024

PR Overview

This PR will address the following Issue/Feature: #120

This PR will result in the following new package version:

v0.12.4

Non breaking as we are not introducing new fields; just solving for potential cross joins due to missing joins on source_relation

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

  • adds the missing source_relation joins to prevent fan outs in the case where the same id's can exist in sibling tables across different schemas.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • [] You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

Will ask the customer to verify this change works. The customer contributed most of these joins, so it should have worked for them but we can double check since we added a few more lines.

Update-- customer hasn't responded and haven't been able to reproduce the error in our test data environment, but this is a fairly straightforward bug fix

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli fivetran-reneeli self-assigned this Apr 24, 2024
@fivetran-reneeli fivetran-reneeli changed the title initialize source relation fix Apr 25, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli great work on incorporating these changes. I have just one wording suggestion to update in the CHANGELOG. Otherwise, LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-reneeli fivetran-reneeli merged commit 9f75907 into main Apr 30, 2024
1 of 8 checks passed
@fivetran-reneeli fivetran-reneeli deleted the bugfix/source_relations branch April 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Duplicate rows in int_quickbooks__invoice_join.sql model when more than one QuickBooks source
4 participants