Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account class ordering to balance profit loss models #65

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Dec 19, 2022

Are you a current Fivetran customer?

What change(s) does this PR introduce?

  • Added account_class_ordinal to quickbooks__balance_sheet and quickbooks__profit_and_loss to allow customers to order their data by account class type.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes (merging into a separate branch from main, will update version once we have clarity)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • BuildKite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🍏

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

swapping credit and debit accounts
@fivetran-avinash fivetran-avinash changed the title Feature/add account class ordering to balance profit loss models Add account class ordering to balance profit loss models Dec 19, 2022
@fivetran-avinash fivetran-avinash self-assigned this Dec 19, 2022
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-avinash this is looking great, but currently this customization will not work for customers. They will not be able to edit the seed file which then removes the flexibility that we are trying to configure. Additionally, the customer needs to run a dbt build or dbt seed command in order to take advantage of these ordinals. That is a pretty big road block from the majority of our customers who are just running dbt run.

I have a number of comments included in this review that I feel we should modify with this approach in order for the outcome to work in the way we want. Ultimately we want there to be a way for customers to leverage this feature if they want, but not have to worry about it if they don't care to take advantage of it. Currently, regardless if they want it or not, they need to configure change their workflow to account for this feature. We need to add to this feature in order to ensure a seamless workflow for customers that want to use it, and if they don't want to customize the ordinals.

I tried to be thorough in my suggestions, but feel free to reach out if it is not clear. Once we get this working for both situations I think this will be a super powerful feature!

dbt_project.yml Outdated Show resolved Hide resolved
models/quickbooks.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
models/quickbooks__general_ledger_by_period.sql Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-avinash thanks so much for reviewing my comments diligently and applying the updates! The code looks great, I only have a few minor requests to update the README logic.

Once those are applied, I will re-review and we can fold into your updates branch!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dbt_project.yml Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
fivetran-avinash and others added 6 commits January 5, 2023 10:52
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying these updates and they look great! LGTM 🙌

@fivetran-avinash fivetran-avinash merged commit 4b9dace into feature/quickbooks-updates-project Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QUESTION - would ordering of balance sheet / pnl be a reasonable feature request
4 participants