Feature/Cash Flow statement

[fivetran-avinash]

Are you a current Fivetran customer?

What change(s) does this PR introduce?

Did you update the CHANGELOG?

• Yes

Does this PR introduce a breaking change?

• Yes (please provide breaking change details below.)
• No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

• Yes (Will update version on feature/quickbooks-updates-project

Is this PR in response to a previously created Bug or Feature Request

• Yes, Issue/Feature [FEATURE - Cashflow Statement #31]
• No

How did you test the PR changes?

• BuildKite
• Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

• BigQuery
• Redshift
• Snowflake
• Postgres
• Databricks
• Other (provide details below)

Provide an emoji that best describes your current mood

🕵️

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

[fivetran-joemarkiewicz]

@fivetran-avinash I have a few comments and suggestions below. This is looking great though!!

[fivetran-joemarkiewicz]

Thanks for making the previously requested changes @fivetran-avinash!

I just finished the model code review and found it worked great when using the default behavior. However, when using the ordinal seed file I found a fanout to occur. Would you be able to review my notes and adjust the model to resolve the fanout.

[fivetran-joemarkiewicz]

@fivetran-avinash this is looking great and we are so close to closing it out!

I have a few small suggestions and comments included below. Additionally, one last thought I had was the location of the example seed files are pretty hard to find. I know I requested they be put in the integration_tests seeds folder, but as I was working with the package it was a very confusing experience (especially since we have so many other seed files).

What if we instead created a new folder example_ordinal_seeds (or something like that) in the root directory of the package and put the example seeds there. This way it is very clear to customers where the examples are, and when you follow a hyper link it doesn't take you into the deep recesses of the package. Let me know your thoughts!

[fivetran-avinash]

@fivetran-avinash this is looking great and we are so close to closing it out!

I have a few small suggestions and comments included below. Additionally, one last thought I had was the location of the example seed files are pretty hard to find. I know I requested they be put in the integration_tests seeds folder, but as I was working with the package it was a very confusing experience (especially since we have so many other seed files).

What if we instead created a new folder example_ordinal_seeds (or something like that) in the root directory of the package and put the example seeds there. This way it is very clear to customers where the examples are, and when you follow a hyper link it doesn't take you into the deep recesses of the package. Let me know your thoughts!

@fivetran-joemarkiewicz Changes applied!

[fivetran-joemarkiewicz]

Looks great to me!! Thanks for applying all the updates and working with me on the back and forth 😄. Great job @fivetran-avinash

[fivetran-avinash]

Looks great to me!! Thanks for applying all the updates and working with me on the back and forth 😄. Great job @fivetran-avinash

Thanks for all the input @fivetran-joemarkiewicz!