converts sales_item_item_id to string #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @evancole-untitled thanks so much for opening this PR! As I had mentioned in our email chain, I will be sure to test this PR and troubleshoot any remaining issues that may be occurring. I did want to provide a quick update that I will be OOO until next week. I will be sure to review and edit this PR once I am back next week. Thanks again and I will post here with more updates next week. |
14 tasks
fivetran-joemarkiewicz
changed the base branch from
main
to
bugfix/evancole-untitled-casting
|
Hi @evancole-untitled as I had mentioned above, there are a few minor updates I will make before merging to the Feel free to follow along in the new PR for any additional updates. |
fivetran-joemarkiewicz
merged commit b125daf
into
fivetran:bugfix/evancole-untitled-casting
|
Thanks, I definitely will!
…On Thu, Mar 24, 2022 at 2:58 PM Joe Markiewicz ***@***.***> wrote:
Merged #24 <#24>
into bugfix/evancole-untitled-casting.
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVERHMEWNOZBEBHBWL4RMXLVBS3OPANCNFSM5QZ4VYEQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Are you a current Fivetran customer?
Yes. Evan Cole, Data Engineer for Untitled Firm
What change(s) does this PR introduce?
converts sales_item_item_id to type string due to errors created by
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
sales_item_item_id is used in a coalesce in the dbt_quickbooks package, which will break that package unless changes are made to other id fields
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
❌