Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/credit card payments #29

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

Features

  • Addition of the credit_card_payment_txn (enabled/disabled using the using_credit_card_payment_txn variable) source as well as the accompanying staging models. This source includes all credit card payment transactions and will be used in downstream General Ledger generation to ensure accurate reporting of all transaction types.

    Note: the credit_card_payment_txn source and models are disabled by default. In order to enabled them, you will want to set the using_credit_card_payment_txn variable to true in your dbt_project.yml.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

This PR will only add a new intermediate and component in the GL model that is disabled by default. This will not cause existing runs to fail.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💳
Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the enhancement New feature or request label Sep 27, 2022
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left a couple of docs-related comments

just flagging that this package still uses the ~= syntax in the requirements.txt file if we want to change it to >=

note: i do not have access to our quickbooks schema, so i did not run this myself as the customer is also testing it out and circle ci has passed

README.md Show resolved Hide resolved
models/stg_quickbooks__credit_card_payment_txn.sql Outdated Show resolved Hide resolved
models/tmp/stg_quickbooks__credit_card_payment_txn_tmp.sql Outdated Show resolved Hide resolved
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review October 14, 2022 19:45
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to MagicBot/dbt-utils-cross-db-migration October 14, 2022 19:50
@fivetran-joemarkiewicz
Copy link
Contributor Author

Thanks for reviewing @fivetran-jamie! I just updated the package based off your notes and will plan to merge with the dbt-utils and dbt-core updates.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit b2ab899 into MagicBot/dbt-utils-cross-db-migration Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants