Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class ids to source models, add union schema #35

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Nov 24, 2022

Pull Request
Are you a current Fivetran customer?

What change(s) does this PR introduce?

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature #44 from the Quickbooks transform package.
  • No

How did you test the PR changes?

  • Buildkite Build pass
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

馃毜

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from MagicBot/dbt-utils-cross-db-migration to feature/quickbooks-updates-project November 30, 2022 19:17
@fivetran-avinash fivetran-avinash self-assigned this Dec 1, 2022
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-avinash just reviewed and found the updates to work as intended! LGTM

@fivetran-avinash fivetran-avinash changed the title Add class ids to source models Add class ids to source models, add union schema Dec 1, 2022
@fivetran-avinash fivetran-avinash merged commit b9cadd3 into feature/quickbooks-updates-project Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants