Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Slim down last_date logic in int_salesforce__date_spine - use current_date #49

Closed
2 of 4 tasks
fivetran-jamie opened this issue Feb 20, 2024 · 0 comments
Closed
2 of 4 tasks
Labels
enhancement New feature or request

Comments

@fivetran-jamie
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

This came out of #48

This logic seems a bit roundabout and maybe wholly unnecessary, as when would the max(created_at) for a lead or opportunity ever be > the current_date? Perhaps we can automatically use the current_date as the last date for the date_spine, which is typically what we do in other packages.

Describe alternatives you've considered

Leave it and the potentially unnecessary run_queries in there

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant