Fix for syntax error in compiled SQL from sfdc_formula_view_sql macro... #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes syntax issue in the compiled SQL from the sfdc_formula_view_sql macro when using Databricks.
Please provide your name and company
Andrew Corcoran - West Shore Home
Link the issue/feature request which this PR is meant to address
#91
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
When using the package with Databricks, the sfdc_formula_view_sql macro now uses the same replace filter for
`fivetran_formula`
as BigQuery, since the backtick syntax returned from thesource()
function is the same.Before:
After:
How did you validate the changes introduced within this PR?
Local testing with
dbt compile
, Databricks warehouse testing withdbt run
Which warehouse did you use to develop these changes?
Databricks
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
🔨