-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add deprecation full_statement_version=false documentation & warning log #96
Enhancement: Add deprecation full_statement_version=false documentation & warning log #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-avinash these look good! I just have some minor comments in the CHANGELOG and a suggestion to update the warning message. I will hold off approving until the warning message is updated and the results are as we would expect in the logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz Ready for re-review! The new log message appears to be spaced out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These updates look great! All good to go with just one small suggestion to the README
|
||
### (Deprecated) Options 2 and 3 | ||
|
||
**IMPORTANT**: Options 2 and 3 (which leverage the `full_statement_version=false` config) will no longer be supported after October 1. Click 'Expand to view details' if you'd like to still use these options for the time being. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**IMPORTANT**: Options 2 and 3 (which leverage the `full_statement_version=false` config) will no longer be supported after October 1. Click 'Expand to view details' if you'd like to still use these options for the time being. | |
**IMPORTANT**: Options 2 and 3 (which leverage the `full_statement_version=false` config) will no longer be supported after October 1, 2023. Click 'Expand to view details' if you'd like to still use these options for the time being. |
PR Overview
This PR will address the following Issue/Feature: [#95]
This PR will result in the following new package version: 0.9.2
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
full_statement_version=false
. We've highlighted this change to users of the package in the README.dbt run
indicating deprecation of support for those options.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Executed
dbt run
locally and made sure when full-statement-version=false ran the error log was generated.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🌆